Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 310433002: Dust off and fix DUMP_NODE_STATISTICS (Closed)

Created:
6 years, 6 months ago by pdr.
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Visibility:
Public.

Description

Dust off and fix DUMP_NODE_STATISTICS This patch updates DUMP_NODE_STATISTICS as it has gotten stale. Attributes are no longer lazily created so those counts have been removed. Clang does not allow exit time destructors so the static liveNodeSet() function has been added. Lastly, fix a few type errors. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175150

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M Source/core/dom/Node.cpp View 7 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
pdr.
6 years, 6 months ago (2014-05-30 01:35:05 UTC) #1
eseidel
lgtm
6 years, 6 months ago (2014-05-30 01:46:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/310433002/1
6 years, 6 months ago (2014-05-30 01:48:37 UTC) #3
Paweł Hajdan Jr.
The CQ bit was unchecked by phajdan.jr@chromium.org
6 years, 6 months ago (2014-05-30 16:23:48 UTC) #4
Paweł Hajdan Jr.
The CQ bit was checked by phajdan.jr@chromium.org
6 years, 6 months ago (2014-05-30 16:28:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/310433002/1
6 years, 6 months ago (2014-05-30 16:30:51 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 16:32:21 UTC) #7
Message was sent while issue was closed.
Change committed as 175150

Powered by Google App Engine
This is Rietveld 408576698