Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: ui/views/widget/desktop_aura/desktop_root_window_host_x11.h

Issue 31043006: Moves creation of various clients to DesktopNativeWidgetAura (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: resolve merge Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/desktop_aura/desktop_root_window_host_x11.h
diff --git a/ui/views/widget/desktop_aura/desktop_root_window_host_x11.h b/ui/views/widget/desktop_aura/desktop_root_window_host_x11.h
index adef24d135e0f1e1b65c3dc62d318b7a2491a32e..e35dc36ad4936827200977c768863e9fa3da9e4d 100644
--- a/ui/views/widget/desktop_aura/desktop_root_window_host_x11.h
+++ b/ui/views/widget/desktop_aura/desktop_root_window_host_x11.h
@@ -13,7 +13,6 @@
#include "base/basictypes.h"
#include "base/memory/weak_ptr.h"
#include "base/observer_list.h"
-#include "ui/aura/client/cursor_client.h"
#include "ui/aura/root_window_host.h"
#include "ui/base/cursor/cursor_loader_x11.h"
#include "ui/gfx/rect.h"
@@ -21,13 +20,6 @@
#include "ui/views/views_export.h"
#include "ui/views/widget/desktop_aura/desktop_root_window_host.h"
-namespace aura {
-namespace client {
-class FocusClient;
-class ScreenPositionClient;
-}
-}
-
namespace views {
class DesktopDragDropClientAuraX11;
class DesktopDispatcherClient;
@@ -35,10 +27,6 @@ class DesktopRootWindowHostObserverX11;
class X11DesktopWindowMoveClient;
class X11WindowEventFilter;
-namespace corewm {
-class CursorManager;
-}
-
class VIEWS_EXPORT DesktopRootWindowHostX11 :
public DesktopRootWindowHost,
public aura::RootWindowHost,
@@ -46,8 +34,7 @@ class VIEWS_EXPORT DesktopRootWindowHostX11 :
public:
DesktopRootWindowHostX11(
internal::NativeWidgetDelegate* native_widget_delegate,
- DesktopNativeWidgetAura* desktop_native_widget_aura,
- const gfx::Rect& initial_bounds);
+ DesktopNativeWidgetAura* desktop_native_widget_aura);
virtual ~DesktopRootWindowHostX11();
// A way of converting an X11 |xid| host window into a |content_window_|.
@@ -75,9 +62,14 @@ class VIEWS_EXPORT DesktopRootWindowHostX11 :
protected:
// Overridden from DesktopRootWindowHost:
- virtual aura::RootWindow* Init(aura::Window* content_window,
- const Widget::InitParams& params) OVERRIDE;
+ virtual void Init(aura::Window* content_window,
+ const Widget::InitParams& params,
+ aura::RootWindow::CreateParams* rw_create_params) OVERRIDE;
+ virtual void OnRootWindowCreated(aura::RootWindow* root,
+ const Widget::InitParams& params) OVERRIDE;
virtual scoped_ptr<corewm::Tooltip> CreateTooltip() OVERRIDE;
+ virtual scoped_ptr<aura::client::DragDropClient>
+ CreateDragDropClient(DesktopNativeCursorManager* cursor_manager) OVERRIDE;
virtual void Close() OVERRIDE;
virtual void CloseNow() OVERRIDE;
virtual aura::RootWindowHost* AsRootWindowHost() OVERRIDE;
@@ -238,12 +230,9 @@ private:
// We are owned by the RootWindow, but we have to have a back pointer to it.
aura::RootWindow* root_window_;
- // aura:: objects that we own.
- scoped_ptr<aura::client::FocusClient> focus_client_;
- scoped_ptr<views::corewm::CursorManager> cursor_client_;
scoped_ptr<DesktopDispatcherClient> dispatcher_client_;
- scoped_ptr<aura::client::ScreenPositionClient> position_client_;
- scoped_ptr<DesktopDragDropClientAuraX11> drag_drop_client_;
+
+ DesktopDragDropClientAuraX11* drag_drop_client_;
// Current Aura cursor.
gfx::NativeCursor current_cursor_;

Powered by Google App Engine
This is Rietveld 408576698