Fixes the deploy step used by the bots in windows

pkg/polymer/lib/deploy.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * **Note**: If you already have a `build.dart` in your application, we
  * recommend to use the `package:polymer/builder.dart` library instead.
 
  * Temporary deploy command used to create a version of the app that can be
  * compiled with dart2js and deployed. Following pub layout conventions, this
@@ skipping 20 matching lines @@
 import 'src/build/runner.dart';
 import 'transformer.dart';
 
 main() {
   var args = _parseArgs(new Options().arguments);
   if (args == null) exit(1);
 
   var test = args['test'];
   var outDir = args['out'];
 
-  var transformOps = new TransformOptions(
-      directlyIncludeJS: args['js'],
-      contentSecurityPolicy: args['csp']);
-
-  var options = (test == null)
-    ? new BarbackOptions(createDeployPhases(transformOps), outDir)
-    : _createTestOptions(transformOps, test, outDir);
+  var options;
+  if (test == null) {
+    var transformOps = new TransformOptions(
+        directlyIncludeJS: args['js'],
+        contentSecurityPolicy: args['csp']);
+    options = new BarbackOptions(createDeployPhases(transformOps), outDir);
+  } else {
+    options = _createTestOptions(test, outDir, args['js'], args['csp']);
+  }
   if (options == null) exit(1);
 
   print('polymer/deploy.dart: creating a deploy target for '
       '"${options.currentPackage}"');
 
   runBarback(options)
       .then((_) => print('Done! All files written to "$outDir"'))
       .catchError(_reportErrorAndExit);
 }
 
 createDeployPhases(options) => new PolymerTransformerGroup(options).phases;
 
-BarbackOptions _createTestOptions(TransformOptions transformOps,
-    String testFile, String outDir) {
+BarbackOptions _createTestOptions(String testFile, String outDir,
+    bool directlyIncludeJS, bool contentSecurityPolicy) {
   var testDir = path.normalize(path.dirname(testFile));
 
   // A test must be allowed to import things in the package.
   // So we must find its package root, given the entry point. We can do this
   // by walking up to find pubspec.yaml.
   var pubspecDir = _findDirWithFile(path.absolute(testDir), 'pubspec.yaml');
   if (pubspecDir == null) {
     print('error: pubspec.yaml file not found, please run this script from '
         'your package root directory or a subdirectory.');
     return null;
   }
 
-  transformOps.entryPoints = [path.relative(testFile, from: pubspecDir)];

[Siggi Cherem (dart-lang), 2013/10/22 18:57:58]

I didn't realize this yesterday,  but the problem is that we need to use posix
style paths here. I decided to make the field final so that we always go through
the constructor initialization that normalizes paths.

It's not bulletproof because the list can still be mutated later, but it might
help in the future.

-  var phases = createDeployPhases(transformOps);
+  var phases = createDeployPhases(new TransformOptions(
+      entryPoints: [path.relative(testFile, from: pubspecDir)],
+      directlyIncludeJS: directlyIncludeJS,
+      contentSecurityPolicy: contentSecurityPolicy));
   return new BarbackOptions(phases, outDir,
       currentPackage: '_test',
       packageDirs: {'_test' : pubspecDir},
       transformTests: true);
 }
 
 String _findDirWithFile(String dir, String filename) {
   while (!new File(path.join(dir, filename)).existsSync()) {
     var parentDir = path.dirname(dir);
     // If we reached root and failed to find it, bail.
@@ skipping 38 matching lines @@
     _showUsage(parser);
     return null;
   }
 }
 
 _showUsage(parser) {
   print('Usage: dart --package-root=packages/ '
       'package:polymer/deploy.dart [options]');
   print(parser.getUsage());
 }