Issue 31043002: Make content shell activate and focus dev tools on show.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 31043002: Make content shell activate and focus dev tools on show. (Closed)

Created:
7 years, 2 months ago by ljs

Modified:
7 years, 2 months ago

Reviewers:
tkent, jochen (gone - plz use gerrit), pfeldman

CC:
chromium-reviews, vsevik, jam, yurys, joi+watch-content_chromium.org, paulirish+reviews_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Make content shell activate and focus dev tools on show. Add Activate() function to ShellDevToolsFrontend class, and call Activate() and Focus() on Show(). BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229709

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	content/shell/browser/shell_devtools_frontend.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	content/shell/browser/shell_devtools_frontend.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ljs

PTAL Currently the content shell doesn't activate/focus the devtools window when shown, this patch adds ...

7 years, 2 months ago (2013-10-20 15:41:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lstoakes@gmail.com/31043002/1

7 years, 2 months ago (2013-10-20 17:54:34 UTC) #3

Message was sent while issue was closed.

Change committed as 229709

Expand Messages | Collapse Messages