Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: content/browser/frame_host/render_frame_proxy_host.cc

Issue 310413004: Move ownership of CrossProcessFrameConnector to RenderFrameProxyHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_frame_proxy_host.h" 5 #include "content/browser/frame_host/render_frame_proxy_host.h"
6 6
7 #include "content/browser/frame_host/cross_process_frame_connector.h"
7 #include "content/browser/frame_host/frame_tree_node.h" 8 #include "content/browser/frame_host/frame_tree_node.h"
8 #include "content/browser/frame_host/render_frame_host_impl.h" 9 #include "content/browser/frame_host/render_frame_host_impl.h"
10 #include "content/browser/frame_host/render_widget_host_view_child_frame.h"
11 #include "content/browser/renderer_host/render_widget_host_view_base.h"
9 #include "content/browser/site_instance_impl.h" 12 #include "content/browser/site_instance_impl.h"
10 #include "content/common/frame_messages.h" 13 #include "content/common/frame_messages.h"
11 #include "ipc/ipc_message.h" 14 #include "ipc/ipc_message.h"
12 15
16 #include "ipc/ipc_logging.h"
17 #include "ipc/ipc_message_utils.h"
18
13 namespace content { 19 namespace content {
14 20
15 RenderFrameProxyHost::RenderFrameProxyHost(SiteInstance* site_instance, 21 RenderFrameProxyHost::RenderFrameProxyHost(SiteInstance* site_instance,
16 FrameTreeNode* frame_tree_node) 22 FrameTreeNode* frame_tree_node)
17 : routing_id_(site_instance->GetProcess()->GetNextRoutingID()), 23 : routing_id_(site_instance->GetProcess()->GetNextRoutingID()),
18 site_instance_(site_instance), 24 site_instance_(site_instance),
19 frame_tree_node_(frame_tree_node) { 25 frame_tree_node_(frame_tree_node) {
20 GetProcess()->AddRoute(routing_id_, this); 26 GetProcess()->AddRoute(routing_id_, this);
27 LOG(ERROR) << "RFPH::RFPH[" << this << "]:"
28 << " routing_id:" << routing_id_ << ", site:" << site_instance->GetSiteURL() ;
29
30 if (!frame_tree_node_->IsMainFrame() &&
31 frame_tree_node_->parent()->render_manager()->current_frame_host()->GetSit eInstance() ==
32 site_instance) {
33 // The RenderFrameHost being swapped out becomes the proxy for this
34 // frame in its parent's process. CrossProcessFrameConnector
35 // initialization only needs to happen on an initial cross-process
36 // navigation, when the RenderFrame leaves the same process as its parent.
37 // The same CrossProcessFrameConnector is used for subsequent cross-
38 // process navigations, but it will be destroyed if the Frame is
39 // navigated back to the same site instance as its parent.
40 // TODO(kenrb): This will change when RenderFrameProxyHost is created.
41 // TODO(nasko): Move CrossProcessFrameConnector to be owned by
42 // RenderFrameProxyHost instead of RenderFrameHostManager once proxy
43 // support lands.
44 cross_process_frame_connector_.reset(new CrossProcessFrameConnector(this));
45 LOG(ERROR) << "RFPH::RFPH[" << this << "]:"
46 " created CPFC:" << cross_process_frame_connector_.get();
47 }
21 } 48 }
22 49
23 RenderFrameProxyHost::~RenderFrameProxyHost() { 50 RenderFrameProxyHost::~RenderFrameProxyHost() {
24 if (GetProcess()->HasConnection()) 51 if (GetProcess()->HasConnection())
25 Send(new FrameMsg_DeleteProxy(routing_id_)); 52 Send(new FrameMsg_DeleteProxy(routing_id_));
26 53
27 GetProcess()->RemoveRoute(routing_id_); 54 GetProcess()->RemoveRoute(routing_id_);
28 } 55 }
29 56
57 void RenderFrameProxyHost::SetView(RenderWidgetHostView* view) {
58 LOG(ERROR) << "RFPH::SetView[" << this << "]:"
59 << " CPFC:" << cross_process_frame_connector_.get()
60 << " view:" << view;
61 cross_process_frame_connector_->set_view(
62 static_cast<RenderWidgetHostViewChildFrame*>(view));
63 }
64
30 RenderViewHostImpl* RenderFrameProxyHost::GetRenderViewHost() { 65 RenderViewHostImpl* RenderFrameProxyHost::GetRenderViewHost() {
31 if (render_frame_host_.get()) 66 if (render_frame_host_.get())
32 return render_frame_host_->render_view_host(); 67 return render_frame_host_->render_view_host();
33 return NULL; 68 return NULL;
34 } 69 }
35 70
36 scoped_ptr<RenderFrameHostImpl> RenderFrameProxyHost::PassFrameHostOwnership() { 71 scoped_ptr<RenderFrameHostImpl> RenderFrameProxyHost::PassFrameHostOwnership() {
37 render_frame_host_->set_render_frame_proxy_host(NULL); 72 render_frame_host_->set_render_frame_proxy_host(NULL);
38 return render_frame_host_.Pass(); 73 return render_frame_host_.Pass();
39 } 74 }
40 75
41 bool RenderFrameProxyHost::Send(IPC::Message *msg) { 76 bool RenderFrameProxyHost::Send(IPC::Message *msg) {
42 // TODO(nasko): For now, RenderFrameHost uses this object to send IPC messages 77 // TODO(nasko): For now, RenderFrameHost uses this object to send IPC messages
43 // while swapped out. This can be removed once we don't have a swapped out 78 // while swapped out. This can be removed once we don't have a swapped out
44 // state on RenderFrameHosts. See https://crbug.com/357747. 79 // state on RenderFrameHosts. See https://crbug.com/357747.
45 msg->set_routing_id(routing_id_); 80 msg->set_routing_id(routing_id_);
46 return GetProcess()->Send(msg); 81 return GetProcess()->Send(msg);
47 } 82 }
48 83
49 bool RenderFrameProxyHost::OnMessageReceived(const IPC::Message& msg) { 84 bool RenderFrameProxyHost::OnMessageReceived(const IPC::Message& msg) {
85
86 IPC::LogData data;
87 IPC::GenerateLogData("", msg, &data, true);
88 LOG(ERROR) << "RFPH::OnMessageReceived: [" << this << "]: " << data.message_na me;
89
90 if (cross_process_frame_connector_.get() &&
91 cross_process_frame_connector_->OnMessageReceived(msg))
92 return true;
93
50 // TODO(nasko): This can be removed once we don't have a swapped out state on 94 // TODO(nasko): This can be removed once we don't have a swapped out state on
51 // RenderFrameHosts. See https://crbug.com/357747. 95 // RenderFrameHosts. See https://crbug.com/357747.
52 if (render_frame_host_.get()) 96 if (render_frame_host_.get())
53 return render_frame_host_->OnMessageReceived(msg); 97 return render_frame_host_->OnMessageReceived(msg);
54 98
55 return false; 99 return false;
56 } 100 }
57 101
58 } // namespace content 102 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698