Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 310413002: Temporary fix for fast/events/touch/gesture/pad-gesture-fling.html crash. (Closed)

Created:
6 years, 6 months ago by wibling-chromium
Modified:
6 years, 6 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Temporary fix for fast/events/touch/gesture/pad-gesture-fling.html crash. The test crashes because the createFlingAnimationCurve call hits the int version in Platform.h which is no longer matching the signature in content/test/test_webkit_platform_support.h (and content/child/blink_platform_impl.h). Instead it hits the default one in Platform.h which just returns 0. Subsequently the WebActiveGestureAnimation calls through the null pointer in WebActiveGestureAnimation::animate. TBR=rjkroege@chromium.org, jam@chromium.org, ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175493

Patch Set 1 #

Patch Set 2 : change to static_cast. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/web/WebViewImpl.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
wibling-chromium
6 years, 6 months ago (2014-06-04 12:29:17 UTC) #1
haraken
Just help me understand: Is this crash happening only on oilpan-builds? I just want to ...
6 years, 6 months ago (2014-06-04 12:39:42 UTC) #2
wibling-chromium
On 2014/06/04 12:39:42, haraken wrote: > Just help me understand: Is this crash happening only ...
6 years, 6 months ago (2014-06-04 12:50:56 UTC) #3
wibling-chromium
The CQ bit was checked by wibling@chromium.org
6 years, 6 months ago (2014-06-04 12:52:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wibling@chromium.org/310413002/20001
6 years, 6 months ago (2014-06-04 12:52:25 UTC) #5
haraken
On 2014/06/04 12:50:56, wibling-chromium wrote: > On 2014/06/04 12:39:42, haraken wrote: > > Just help ...
6 years, 6 months ago (2014-06-04 12:54:14 UTC) #6
zerny-chromium
lgtm
6 years, 6 months ago (2014-06-04 13:39:55 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-04 14:19:09 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 15:31:35 UTC) #9
Message was sent while issue was closed.
Change committed as 175493

Powered by Google App Engine
This is Rietveld 408576698