Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1862)

Unified Diff: Source/web/NotificationPresenterImpl.cpp

Issue 310393004: Oilpan: update WebNotification and WebDOMMediaStreamTrack type conversions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use RawPtr for WebNotification Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/web/WebDOMMediaStreamTrack.cpp » ('j') | public/web/WebNotification.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/NotificationPresenterImpl.cpp
diff --git a/Source/web/NotificationPresenterImpl.cpp b/Source/web/NotificationPresenterImpl.cpp
index 0d926ea7eee001cc75ce02c030cc954db889bae5..ae8361577162e587efc8978ac17a861f44536848 100644
--- a/Source/web/NotificationPresenterImpl.cpp
+++ b/Source/web/NotificationPresenterImpl.cpp
@@ -79,20 +79,20 @@ bool NotificationPresenterImpl::isInitialized()
bool NotificationPresenterImpl::show(Notification* notification)
{
- return m_presenter->show(PassRefPtr<Notification>(notification));
+ return m_presenter->show(RawPtr<Notification>(notification));
Mads Ager (chromium) 2014/06/06 06:45:17 I think these methods already take actual raw poin
sof 2014/06/06 06:50:28 No, that runs into issues with converting a Notifi
Mads Ager (chromium) 2014/06/06 07:13:20 OK, thanks. :(
sof 2014/06/06 07:23:06 There's stuff to be looked at wrt WebPrivatePtr<>,
}
void NotificationPresenterImpl::close(Notification* notification)
{
- m_presenter->close(PassRefPtr<Notification>(notification));
+ m_presenter->close(RawPtr<Notification>(notification));
// FIXME: Remove the duplicated call to cancel() when Chromium updated to override close() instead.
- m_presenter->cancel(PassRefPtr<Notification>(notification));
+ m_presenter->cancel(RawPtr<Notification>(notification));
}
void NotificationPresenterImpl::notificationObjectDestroyed(Notification* notification)
{
- m_presenter->objectDestroyed(PassRefPtr<Notification>(notification));
+ m_presenter->objectDestroyed(RawPtr<Notification>(notification));
}
NotificationClient::Permission NotificationPresenterImpl::checkPermission(ExecutionContext* context)
« no previous file with comments | « no previous file | Source/web/WebDOMMediaStreamTrack.cpp » ('j') | public/web/WebNotification.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698