Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa_browsertest.mm

Issue 310383004: Make a controller interface for media galleries dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/utf_string_conversions.h"
5 #include "chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h" 6 #include "chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h"
6 7
7 #include "chrome/browser/media_galleries/media_galleries_dialog_controller_mock. h" 8 #include "chrome/browser/media_galleries/media_galleries_dialog_controller_mock. h"
8 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
9 #include "chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.h" 10 #include "chrome/browser/ui/cocoa/constrained_window/constrained_window_alert.h"
10 #include "chrome/browser/ui/tabs/tab_strip_model.h" 11 #include "chrome/browser/ui/tabs/tab_strip_model.h"
11 #include "chrome/test/base/in_process_browser_test.h" 12 #include "chrome/test/base/in_process_browser_test.h"
12 #include "components/web_modal/web_contents_modal_dialog_manager.h" 13 #include "components/web_modal/web_contents_modal_dialog_manager.h"
13 #include "content/public/test/test_utils.h" 14 #include "content/public/test/test_utils.h"
14 #include "extensions/common/extension.h" 15 #include "extensions/common/extension.h"
Lei Zhang 2014/06/05 07:56:25 remove extensions #includes?
vandebo (ex-Chrome) 2014/06/05 19:25:29 Done.
15 #include "extensions/common/test_util.h" 16 #include "extensions/common/test_util.h"
16 #include "testing/gtest/include/gtest/gtest.h" 17 #include "testing/gtest/include/gtest/gtest.h"
17 18
19 using ::testing::_;
20 using ::testing::AnyNumber;
18 using ::testing::NiceMock; 21 using ::testing::NiceMock;
19 using ::testing::Return; 22 using ::testing::Return;
20 using ::testing::ReturnRef; 23 using ::testing::ReturnRef;
21 using web_modal::WebContentsModalDialogManager; 24 using web_modal::WebContentsModalDialogManager;
22 25
23 class MediaGalleriesDialogBrowserTest : public InProcessBrowserTest { 26 class MediaGalleriesDialogBrowserTest : public InProcessBrowserTest {
24 }; 27 };
25 28
26 // Verify that programatically closing the constrained window correctly closes 29 // Verify that programatically closing the constrained window correctly closes
27 // the sheet. 30 // the sheet.
28 IN_PROC_BROWSER_TEST_F(MediaGalleriesDialogBrowserTest, Close) { 31 IN_PROC_BROWSER_TEST_F(MediaGalleriesDialogBrowserTest, Close) {
29 scoped_refptr<extensions::Extension> dummy_extension = 32 NiceMock<MediaGalleriesDialogControllerMock> controller;
30 extensions::test_util::CreateExtensionWithID("dummy");
31 NiceMock<MediaGalleriesDialogControllerMock> controller(*dummy_extension);
32 33
33 content::WebContents* web_contents = 34 content::WebContents* web_contents =
34 browser()->tab_strip_model()->GetActiveWebContents(); 35 browser()->tab_strip_model()->GetActiveWebContents();
35 EXPECT_CALL(controller, web_contents()). 36 EXPECT_CALL(controller, web_contents()).
36 WillRepeatedly(Return(web_contents)); 37 WillRepeatedly(Return(web_contents));
37 38 std::vector<base::string16> headers;
38 MediaGalleriesDialogController::GalleryPermissionsVector attached_permissions; 39 headers.push_back(base::string16());
39 EXPECT_CALL(controller, AttachedPermissions()). 40 headers.push_back(base::ASCIIToUTF16("header2"));
40 WillRepeatedly(Return(attached_permissions)); 41 ON_CALL(controller, GetSectionHeaders()).
41 MediaGalleriesDialogController::GalleryPermissionsVector 42 WillByDefault(Return(headers));
42 unattached_permissions; 43 EXPECT_CALL(controller, GetAuxilliaryButtonText()).
43 EXPECT_CALL(controller, UnattachedPermissions()). 44 WillRepeatedly(Return(base::ASCIIToUTF16("button")));
44 WillRepeatedly(Return(unattached_permissions)); 45 EXPECT_CALL(controller, GetSectionEntries(_)).
46 Times(AnyNumber());
45 47
46 scoped_ptr<MediaGalleriesDialogCocoa> dialog( 48 scoped_ptr<MediaGalleriesDialogCocoa> dialog(
47 static_cast<MediaGalleriesDialogCocoa*>( 49 static_cast<MediaGalleriesDialogCocoa*>(
48 MediaGalleriesDialog::Create(&controller))); 50 MediaGalleriesDialog::Create(&controller)));
49 base::scoped_nsobject<NSWindow> window([[dialog->alert_ window] retain]); 51 base::scoped_nsobject<NSWindow> window([[dialog->alert_ window] retain]);
50 EXPECT_TRUE([window isVisible]); 52 EXPECT_TRUE([window isVisible]);
51 53
52 WebContentsModalDialogManager* web_contents_modal_dialog_manager = 54 WebContentsModalDialogManager* web_contents_modal_dialog_manager =
53 WebContentsModalDialogManager::FromWebContents(web_contents); 55 WebContentsModalDialogManager::FromWebContents(web_contents);
54 WebContentsModalDialogManager::TestApi test_api( 56 WebContentsModalDialogManager::TestApi test_api(
55 web_contents_modal_dialog_manager); 57 web_contents_modal_dialog_manager);
56 test_api.CloseAllDialogs(); 58 test_api.CloseAllDialogs();
57 EXPECT_FALSE([window isVisible]); 59 EXPECT_FALSE([window isVisible]);
58 } 60 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698