Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 310373002: Make PlatformAppBrowserTest....AdjustBoundsTo... not flaky (Closed)

Created:
6 years, 6 months ago by benwells
Modified:
6 years, 6 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Make PlatformAppBrowserTest....AdjustBoundsTo... not flaky Full test name is PlatformAppBrowserTest.AppWindowAdjustBoundsToBeVisibleOnScreen After launching an app, tests need to wait for the launch to be complete. If this isn't done the window will potentially be created after the system starts shutting down, causing the system to hang at shutdown. BUG=377754 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275362

Patch Set 1 #

Patch Set 2 : Make it not flaky #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/apps/app_browsertest.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Matt Giuca
lgtm
6 years, 6 months ago (2014-06-05 08:47:54 UTC) #1
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 6 months ago (2014-06-05 09:44:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/310373002/20001
6 years, 6 months ago (2014-06-05 09:44:45 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 10:19:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 10:21:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/34662) linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_dbg/builds/31657) linux_chromium_gn_rel ...
6 years, 6 months ago (2014-06-05 10:21:54 UTC) #6
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 6 months ago (2014-06-05 23:15:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/310373002/40001
6 years, 6 months ago (2014-06-05 23:17:36 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 09:57:19 UTC) #9
Message was sent while issue was closed.
Change committed as 275362

Powered by Google App Engine
This is Rietveld 408576698