Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 310333004: Extend bounds check elimination to constant keys. (Closed)

Created:
6 years, 6 months ago by Yang
Modified:
6 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Extend bounds check elimination to constant keys. R=jkummerow@chromium.org BUG=v8:3367 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21672

Patch Set 1 #

Patch Set 2 : test cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -34 lines) Patch
M src/hydrogen-bce.cc View 2 chunks +52 lines, -34 lines 0 comments Download
A test/mjsunit/bounds-checks-elimination.js View 1 1 chunk +123 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
6 years, 6 months ago (2014-06-04 09:21:27 UTC) #1
Jakob Kummerow
LGTM if you add a test that exercises this code path. (No need to assert ...
6 years, 6 months ago (2014-06-04 11:00:09 UTC) #2
Yang
On 2014/06/04 11:00:09, Jakob wrote: > LGTM if you add a test that exercises this ...
6 years, 6 months ago (2014-06-04 11:46:11 UTC) #3
Jakob Kummerow
Thanks! LGTM.
6 years, 6 months ago (2014-06-04 11:48:47 UTC) #4
Yang
6 years, 6 months ago (2014-06-04 11:52:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r21672 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698