Oilpan: Remove ~HTMLMediaElement document access when the document is destructed.

Oilpan: Remove ~HTMLMediaElement document access when the document is destructed.

The document() accessor on all Nodes end up touching the document. The
reason is that the document accessor gets the document from the
TreeScope which is often the document itself. Therefore, we cannot
use the document() accessor in Node destructors. Fortunately, there
is a more direct way of checking if the Document has been destructed.
HTMLMediaElement is an ActiveDOMObject which is a
ContextLifecycleObserver. Therefore, ActiveDOMObject::executionContext
will tell us if the Document is still alive so that we can access it.

R=haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@chromium.org, zerny@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175465

[sof, 2014-06-04 08:37:21]

lgtm

https://codereview.chromium.org/310333003/diff/1/Source/core/html/HTMLMediaEl...
File Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/310333003/diff/1/Source/core/html/HTMLMediaEl...
Source/core/html/HTMLMediaElement.cpp:319: if
(ActiveDOMObject::executionContext()) {
nit: braces seem superfluous.

[zerny-chromium, 2014-06-04 08:39:59]

lgtm

[Mads Ager (chromium), 2014-06-04 08:41:54]

https://codereview.chromium.org/310333003/diff/1/Source/core/html/HTMLMediaEl...
File Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/310333003/diff/1/Source/core/html/HTMLMediaEl...
Source/core/html/HTMLMediaElement.cpp:319: if
(ActiveDOMObject::executionContext()) {
On 2014/06/04 08:37:21, sof wrote:
> nit: braces seem superfluous.

Removed. Thanks. :)

[Mads Ager (chromium), 2014-06-04 08:42:28]

The CQ bit was checked by ager@chromium.org

[commit-bot: I haz the power, 2014-06-04 08:42:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ager@chromium.org/310333003/20001

[haraken, 2014-06-04 08:46:12]

LGTM

[commit-bot: I haz the power, 2014-06-04 09:54:30]

Change committed as 175465