Fix SafeSPrintfTest.Truncation in base_unittests

base/strings/safe_sprintf_unittest.cc

Index: base/strings/safe_sprintf_unittest.cc
diff --git a/base/strings/safe_sprintf_unittest.cc b/base/strings/safe_sprintf_unittest.cc
index 937fa4eca2329342377ce1596199b62bf3b37935..c2033f32bc88b03afbeefd977a55c8a7d89f605f 100644
--- a/base/strings/safe_sprintf_unittest.cc
+++ b/base/strings/safe_sprintf_unittest.cc
@@ -4,6 +4,7 @@
 
 #include "base/strings/safe_sprintf.h"
 
+#include <inttypes.h>

[Mark Mentovai, 2014/06/15 12:27:26]

Does MSVC even have this header?

[Yang Gu, 2014/06/16 10:39:09]

Not quite sure about MSVC. I searched the web and seems it might not contain
this header. 
I see some other places in this file use "%llX" (switch back to original format)
as format and cast pointer to "(unsigned long long)(uintptr_t)". Looks ok
according to my test on 32-bit and 64-bit.

 #include <stdio.h>
 #include <string.h>
 
@@ -424,9 +425,9 @@ void PrintLongString(char* buf, size_t sz) {
   //       are all really awkward.
   char ref[256];
   CHECK_LE(sz, sizeof(ref));
-  sprintf(ref, "A long string: %%d 00DEADBEEF %lld 0x%llX <NULL>",
+  sprintf(ref, "A long string: %%d 00DEADBEEF %lld 0x%" PRIXPTR " <NULL>",

[Mark Mentovai, 2014/06/15 12:19:21]

Why can’t you use %p here?

[Yang Gu, 2014/06/16 10:39:09]

The actual format is in SafeSNPrintf(), where %p is formatted as upper case. But
the expected result is in sprintf, where %p is in lower case.

           static_cast<long long>(std::numeric_limits<intptr_t>::min()),

[Mark Mentovai, 2014/06/15 12:19:22]

Wouldn’t PRIdPTR (and no cast) be better here and in the format strings used
above on lines 379 and 381?

[Mark Mentovai, 2014/06/15 12:23:02]

Mark Mentovai wrote:
Never mind, I see that %d is intentionally used above, in the comment on line
370.

[Mark Mentovai, 2014/06/15 12:27:26]

Mark Mentovai wrote:
The “never mind” applies to lines 379 and 381. I still think PRIdPTR would be
better down here.

[Yang Gu, 2014/06/16 10:39:09]

PRIdPTR is in decimal format, but we actually need hexadecimal format (%p). 

-          (long long)PrintLongString);
+          (uintptr_t)PrintLongString);
   ref[sz-1] = '\000';
 
 #if defined(NDEBUG)