Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 310313005: [Second try] Add creation of v14 compatible resources to process_resources.py (Closed)

Created:
6 years, 6 months ago by cjhopman
Modified:
6 years, 6 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

[Second try] Add creation of v14 compatible resources to process_resources.py There are a lot of steps in processing resources and preparing them for packaging. It will be easier if these are all done by the same script. BUG=375431, 359249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275645

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add v14_verify_only to apks #

Patch Set 3 : Something new slipped in... fix that #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -60 lines) Patch
M build/android/gyp/generate_v14_compatible_resources.py View 4 chunks +16 lines, -14 lines 0 comments Download
M build/android/gyp/process_resources.py View 6 chunks +25 lines, -2 lines 0 comments Download
M build/grit_action.gypi View 1 chunk +1 line, -1 line 0 comments Download
M build/java.gypi View 5 chunks +12 lines, -36 lines 0 comments Download
M build/java_apk.gypi View 1 2 4 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
cjhopman
First patchset is the same as https://codereview.chromium.org/321453002/ Second patchset adds the v14_verify_only option for apk ...
6 years, 6 months ago (2014-06-06 17:38:56 UTC) #1
newt (away)
https://codereview.chromium.org/310313005/diff/1/build/java_apk.gypi File build/java_apk.gypi (right): https://codereview.chromium.org/310313005/diff/1/build/java_apk.gypi#newcode452 build/java_apk.gypi:452: 'additional_res_dirs=': [], why remove additional_res_dirs?
6 years, 6 months ago (2014-06-06 21:36:57 UTC) #2
cjhopman
https://codereview.chromium.org/310313005/diff/1/build/java_apk.gypi File build/java_apk.gypi (right): https://codereview.chromium.org/310313005/diff/1/build/java_apk.gypi#newcode452 build/java_apk.gypi:452: 'additional_res_dirs=': [], On 2014/06/06 21:36:57, newt wrote: > why ...
6 years, 6 months ago (2014-06-06 21:39:27 UTC) #3
newt (away)
whoops, didn't notice that patch set. lgtm.
6 years, 6 months ago (2014-06-06 22:09:22 UTC) #4
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 6 months ago (2014-06-06 22:09:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/310313005/40001
6 years, 6 months ago (2014-06-06 22:11:33 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-07 02:31:18 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 08:28:09 UTC) #8
Message was sent while issue was closed.
Change committed as 275645

Powered by Google App Engine
This is Rietveld 408576698