Make IPC::Channel polymorphic

ipc/ipc_channel_nacl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IPC_IPC_CHANNEL_NACL_H_
 #define IPC_IPC_CHANNEL_NACL_H_
 
 #include <deque>
 #include <string>
 
 #include "base/memory/linked_ptr.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/process/process.h"
 #include "base/threading/simple_thread.h"
 #include "ipc/ipc_channel.h"
 #include "ipc/ipc_channel_reader.h"
 
 namespace IPC {
 
 // Contains the results from one call to imc_recvmsg (data and file
 // descriptors).
 struct MessageContents;
 
-// Similar to the Posix version of ChannelImpl but for Native Client code.
+// Similar to the ChannelPosix but for Native Client code.
 // This is somewhat different because sendmsg/recvmsg here do not follow POSIX
 // semantics. Instead, they are implemented by a custom embedding of
 // NaClDescCustom. See NaClIPCAdapter for the trusted-side implementation.
 //
 // We don't need to worry about complicated set up and READWRITE mode for
 // sharing handles. We also currently do not support passing file descriptors or
 // named pipes, and we use background threads to emulate signaling when we can
 // read or write without blocking.
-class Channel::ChannelImpl : public internal::ChannelReader {
+class ChannelNacl : public Channel,
+                    public internal::ChannelReader {
  public:
   // Mirror methods of Channel, see ipc_channel.h for description.
-  ChannelImpl(const IPC::ChannelHandle& channel_handle,
+  ChannelNacl(const IPC::ChannelHandle& channel_handle,
               Mode mode,
               Listener* listener);
-  virtual ~ChannelImpl();
+  virtual ~ChannelNacl();
 
   // Channel implementation.
-  base::ProcessId peer_pid() const;
-  bool Connect();
-  void Close();
-  bool Send(Message* message);
+  virtual base::ProcessId peer_pid() const OVERRIDE;
+  virtual bool Connect() OVERRIDE;
+  virtual void Close() OVERRIDE;
+  virtual bool Send(Message* message) OVERRIDE;
 
   // Posted to the main thread by ReaderThreadRunner.
   void DidRecvMsg(scoped_ptr<MessageContents> contents);
   void ReadDidFail();
 
  private:
   class ReaderThreadRunner;
 
   bool CreatePipe(const IPC::ChannelHandle& channel_handle);
   bool ProcessOutgoingMessages();
@@ skipping 46 matching lines @@
   // Queue of file descriptors extracted from imc_recvmsg messages.
   // NOTE: The implementation assumes underlying storage here is contiguous, so
   // don't change to something like std::deque<> without changing the
   // implementation!
   std::vector<int> input_fds_;
 
   // This queue is used when a message is sent prior to Connect having been
   // called. Normally after we're connected, the queue is empty.
   std::deque<linked_ptr<Message> > output_queue_;
 
-  base::WeakPtrFactory<ChannelImpl> weak_ptr_factory_;
+  base::WeakPtrFactory<ChannelNacl> weak_ptr_factory_;
 
-  DISALLOW_IMPLICIT_CONSTRUCTORS(ChannelImpl);
+  DISALLOW_IMPLICIT_CONSTRUCTORS(ChannelNacl);
 };
 
 }  // namespace IPC
 
 #endif  // IPC_IPC_CHANNEL_NACL_H_