Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 310283004: remove SkBitmap::allocConfigPixels and update dox (Closed)

Created:
6 years, 6 months ago by reed1
Modified:
6 years, 6 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

remove SkBitmap::allocConfigPixels and update dox I see no callers in android TBR= Committed: https://skia.googlesource.com/skia/+/ddd014e65264e3f18b2d4305dd2fbc81549f5180

Patch Set 1 #

Patch Set 2 : remove unused function #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -147 lines) Patch
M gm/gmmain.cpp View 4 chunks +18 lines, -20 lines 0 comments Download
M include/core/SkBitmap.h View 1 22 chunks +47 lines, -65 lines 3 comments Download
M src/core/SkBitmap.cpp View 1 4 chunks +2 lines, -62 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
reed1
6 years, 6 months ago (2014-06-05 00:44:42 UTC) #1
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-05 14:42:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/310283004/1
6 years, 6 months ago (2014-06-05 14:43:56 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 14:55:11 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 15:00:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on tryserver.chromium (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/10)
6 years, 6 months ago (2014-06-05 15:00:05 UTC) #6
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-05 15:02:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/310283004/20001
6 years, 6 months ago (2014-06-05 15:03:14 UTC) #8
commit-bot: I haz the power
Change committed as ddd014e65264e3f18b2d4305dd2fbc81549f5180
6 years, 6 months ago (2014-06-05 15:51:24 UTC) #9
scroggo
6 years, 6 months ago (2014-06-05 16:59:34 UTC) #10
Message was sent while issue was closed. 
https://codereview.chromium.org/310283004/diff/20001/include/core/SkBitmap.h
File include/core/SkBitmap.h (right):

https://codereview.chromium.org/310283004/diff/20001/include/core/SkBitmap.h#...
include/core/SkBitmap.h:57: Config  config() const;
Should we deprecate this one too?

https://codereview.chromium.org/310283004/diff/20001/include/core/SkBitmap.h#...
include/core/SkBitmap.h:60: Config  getConfig() const { return this->config(); }
Does Chrome still use this version? I removed Android's callers a while ago (and
I don't think any have snuck back in without me catching them).

https://codereview.chromium.org/310283004/diff/20001/include/core/SkBitmap.h#...
include/core/SkBitmap.h:230: #ifdef SK_SUPPORT_LEGACY_COMPUTE_CONFIG_SIZE
This needs to be defined in skia_for_android_framework_defines (this CL broke
Android).

Powered by Google App Engine
This is Rietveld 408576698