Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 310253005: [SyncFS] Shutdown LocalFileSyncService (Closed)

Created:
6 years, 6 months ago by peria
Modified:
6 years, 6 months ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Visibility:
Public.

Description

[SyncFS] Shutdown LocalFileSyncService before resetting it. BUG=381050 TEST=./unit_tests --gtest_filter="DriveBackendSyncTest.*" --gtest_repeat=-1 with ASAN build Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
peria
PTL
6 years, 6 months ago (2014-06-06 02:41:15 UTC) #1
tzik
lgtm
6 years, 6 months ago (2014-06-06 03:05:58 UTC) #2
nhiroki
lgtm
6 years, 6 months ago (2014-06-06 03:13:34 UTC) #3
peria
The CQ bit was checked by peria@chromium.org
6 years, 6 months ago (2014-06-06 03:20:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/310253005/1
6 years, 6 months ago (2014-06-06 03:22:41 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 07:27:36 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 07:45:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/149404)
6 years, 6 months ago (2014-06-06 07:45:54 UTC) #8
peria
The CQ bit was checked by peria@chromium.org
6 years, 6 months ago (2014-06-06 07:51:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/310253005/1
6 years, 6 months ago (2014-06-06 07:53:37 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 09:27:40 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 11:34:46 UTC) #12
Message was sent while issue was closed.
Change committed as 275411

Powered by Google App Engine
This is Rietveld 408576698