Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: dart/sdk/lib/_internal/pub/asset/dart/serialize/transform.dart

Issue 310233002: Expose aggregate transformers in pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: code review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/pub/asset/dart/serialize/transform.dart
diff --git a/dart/sdk/lib/_internal/pub/asset/dart/serialize/transform.dart b/dart/sdk/lib/_internal/pub/asset/dart/serialize/transform.dart
index 38e2ff1d0f48ad1ecc18cebf081b1c11c150870b..911f6f624e00b4070e10be41a214a8920e56408a 100644
--- a/dart/sdk/lib/_internal/pub/asset/dart/serialize/transform.dart
+++ b/dart/sdk/lib/_internal/pub/asset/dart/serialize/transform.dart
@@ -6,14 +6,13 @@ library pub.asset.serialize.transform;
import 'dart:async';
import 'dart:isolate';
-import 'dart:convert';
import 'package:barback/barback.dart';
// TODO(nweiz): don't import from "src" once issue 14966 is fixed.
import 'package:barback/src/internal_asset.dart';
import '../serialize.dart';
-import '../utils.dart';
+import 'get_input_transform.dart';
/// Serialize the methods shared between [Transform] and [DeclaringTransform].
///
@@ -107,7 +106,8 @@ class _ForeignBaseTransform {
/// A wrapper for a [Transform] that's in the host isolate.
///
/// This retrieves inputs from and sends outputs and logs to the host isolate.
-class ForeignTransform extends _ForeignBaseTransform implements Transform {
+class ForeignTransform extends _ForeignBaseTransform
+ with GetInputTransform implements Transform {
final Asset primaryInput;
/// Creates a transform from a serialized map sent from the host isolate.
@@ -122,21 +122,6 @@ class ForeignTransform extends _ForeignBaseTransform implements Transform {
}).then(deserializeAsset);
}
- Future<String> readInputAsString(AssetId id, {Encoding encoding}) {
- if (encoding == null) encoding = UTF8;
- return getInput(id).then((input) => input.readAsString(encoding: encoding));
- }
-
- Stream<List<int>> readInput(AssetId id) =>
- futureStream(getInput(id).then((input) => input.read()));
-
- Future<bool> hasInput(AssetId id) {
- return getInput(id).then((_) => true).catchError((error) {
- if (error is AssetNotFoundException && error.id == id) return false;
- throw error;
- });
- }
-
void addOutput(Asset output) {
call(_port, {
'type': 'addOutput',

Powered by Google App Engine
This is Rietveld 408576698