Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 310223002: Get most of the View Manager client lib tests to pass again. (Closed)

Created:
6 years, 6 months ago by Ben Goodger (Google)
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Get most of the View Manager client lib tests to pass again. TBD: the ones involving the destruction of one connections. ** not tested as part of main chrome test suite ** R=sky@chromium.org http://crbug.com/365012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274705

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -260 lines) Patch
M mojo/services/public/cpp/view_manager/lib/view_manager_synchronizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_tree_node.cc View 2 chunks +5 lines, -14 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_manager_unittest.cc View 9 chunks +212 lines, -232 lines 0 comments Download
M mojo/services/public/cpp/view_manager/tests/view_tree_node_unittest.cc View 7 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
6 years, 6 months ago (2014-06-03 23:05:52 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-03 23:24:01 UTC) #2
Ben Goodger (Google)
6 years, 6 months ago (2014-06-04 02:47:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r274705 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698