Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 310213003: kiosk: Ensures "Apps" menu visible on launch error. (Closed)

Created:
6 years, 6 months ago by xiyuan
Modified:
6 years, 6 months ago
Reviewers:
zel
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

kiosk: Ensures "Apps" menu visible on launch error. So that the launch error bubble is shown and recorded launcher error is cleared and no longer blocker future launch attempt. BUG=379973 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274763

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/login/apps_menu.js View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
xiyuan
"Apps" menu has to be visible in order to show and clear the launch error. ...
6 years, 6 months ago (2014-06-03 22:46:03 UTC) #1
zel
lgtm
6 years, 6 months ago (2014-06-03 22:59:22 UTC) #2
xiyuan
The CQ bit was checked by xiyuan@chromium.org
6 years, 6 months ago (2014-06-03 23:09:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/310213003/1
6 years, 6 months ago (2014-06-03 23:11:09 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 11:08:39 UTC) #5
Message was sent while issue was closed.
Change committed as 274763

Powered by Google App Engine
This is Rietveld 408576698