Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 310193002: linux_aura: Theoretical crash for full screen transition. (Closed)

Created:
6 years, 6 months ago by Elliot Glaysher
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

linux_aura: Theoretical crash for full screen transition. The only way this crash could occur is if we're trying to layout the titlebar, the delegate requests showing the icon, but there isn't an icon view. In such cases, we shouldn't try to set the bounds on a NULL view. (This fix is theoretical; I wasn't able to repro the bug.) BUG=376313 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274749

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/views/frame/opaque_browser_frame_view_layout.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Elliot Glaysher
6 years, 6 months ago (2014-06-03 21:16:43 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-03 22:07:36 UTC) #2
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 6 months ago (2014-06-03 22:09:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/310193002/1
6 years, 6 months ago (2014-06-03 22:11:26 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 00:07:14 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-04 00:49:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/159418)
6 years, 6 months ago (2014-06-04 00:49:41 UTC) #7
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 6 months ago (2014-06-04 00:56:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/310193002/1
6 years, 6 months ago (2014-06-04 00:57:35 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 09:30:28 UTC) #10
Message was sent while issue was closed.
Change committed as 274749

Powered by Google App Engine
This is Rietveld 408576698