Small cleanup for the mojo java classes.

Small cleanup for the mojo java classes.

R=rmcilroy@chromium.org, viettrungluu@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274840

[rmcilroy, 2014-06-03 15:48:23]

lgtm once the comment is addressed.

https://codereview.chromium.org/310073002/diff/1/mojo/android/javatests/src/o...
File mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java
(right):

https://codereview.chromium.org/310073002/diff/1/mojo/android/javatests/src/o...
mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java:73:
in.writeMessage(buffer, null, WriteFlags.NONE);
I think it would be cleaner if you avoid importing any inner *Flags classes and
explicitly prefix each with the correct outer class (e.g.,
MessagePipeHandler.WriteFlags.NONE here), otherwise it's not clear whether these
are MessagePipeHandle.WriteFlags or DataPipe.WriteFlags without looking up at
the imports. Could you do this throughout this file please to keep things
consistent.

[qsr, 2014-06-03 15:59:44]

https://chromiumcodereview.appspot.com/310073002/diff/1/mojo/android/javatest...
File mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java
(right):

https://chromiumcodereview.appspot.com/310073002/diff/1/mojo/android/javatest...
mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java:73:
in.writeMessage(buffer, null, WriteFlags.NONE);
On 2014/06/03 15:48:23, rmcilroy wrote:
> I think it would be cleaner if you avoid importing any inner *Flags classes
and
> explicitly prefix each with the correct outer class (e.g.,
> MessagePipeHandler.WriteFlags.NONE here), otherwise it's not clear whether
these
> are MessagePipeHandle.WriteFlags or DataPipe.WriteFlags without looking up at
> the imports. Could you do this throughout this file please to keep things
> consistent.

Done.

[rmcilroy, 2014-06-03 16:26:48]

Thanks for doing that.  lgt.

https://chromiumcodereview.appspot.com/310073002/diff/20001/mojo/android/java...
File mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java
(right):

https://chromiumcodereview.appspot.com/310073002/diff/20001/mojo/android/java...
mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java:235:
MessagePipeHandle.ReadMessageResult readMessageResult =
handles.second.readMessage(null,
nit - move everything after the "=" to the next line (I think it fits).

https://chromiumcodereview.appspot.com/310073002/diff/20001/mojo/android/java...
mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java:493:
MessagePipeHandle.ReadMessageResult readMessageResult =
handles.second.readMessage(null,
ditto

[qsr, 2014-06-03 16:31:07]

https://chromiumcodereview.appspot.com/310073002/diff/20001/mojo/android/java...
File mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java
(right):

https://chromiumcodereview.appspot.com/310073002/diff/20001/mojo/android/java...
mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java:235:
MessagePipeHandle.ReadMessageResult readMessageResult =
handles.second.readMessage(null,
On 2014/06/03 16:26:49, rmcilroy wrote:
> nit - move everything after the "=" to the next line (I think it fits).

Done.

https://chromiumcodereview.appspot.com/310073002/diff/20001/mojo/android/java...
mojo/android/javatests/src/org/chromium/mojo/system/impl/CoreImplTest.java:493:
MessagePipeHandle.ReadMessageResult readMessageResult =
handles.second.readMessage(null,
On 2014/06/03 16:26:49, rmcilroy wrote:
> ditto

Done.

[viettrungluu, 2014-06-03 18:11:53]

lgtm

[qsr, 2014-06-04 07:58:59]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-06-04 08:00:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qsr@chromium.org/310073002/40001

[commit-bot: I haz the power, 2014-06-04 15:45:11]

Change committed as 274840