Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 310063002: Add tests for FuncNameInferrer. (Closed)

Created:
6 years, 6 months ago by marja
Modified:
6 years, 6 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Add tests for FuncNameInferrer. There were no explicit tests for FuncNameInferrer (though, some tests might implicitly rely on it working properly in the common cases). Afaics, there were no tests which would exercise inferring two byte function names or escaped function names. R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=21649

Patch Set 1 #

Total comments: 5

Patch Set 2 : code review (rossberg) #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -52 lines) Patch
M test/cctest/cctest.h View 1 2 chunks +55 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +0 lines, -52 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 2 1 chunk +86 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
marja
rossberg, ptal. This is just adding tests, since FuncNameInferring didn't look like well tested territory ...
6 years, 6 months ago (2014-06-03 13:31:30 UTC) #1
rossberg
LGTM with comments https://codereview.chromium.org/310063002/diff/1/test/cctest/cctest.h File test/cctest/cctest.h (right): https://codereview.chromium.org/310063002/diff/1/test/cctest/cctest.h#newcode451 test/cctest/cctest.h:451: CHECK(result->Equals(expected)); Not your CL really, but ...
6 years, 6 months ago (2014-06-03 13:48:46 UTC) #2
marja
thanks for review! https://codereview.chromium.org/310063002/diff/1/test/cctest/cctest.h File test/cctest/cctest.h (right): https://codereview.chromium.org/310063002/diff/1/test/cctest/cctest.h#newcode451 test/cctest/cctest.h:451: CHECK(result->Equals(expected)); On 2014/06/03 13:48:46, rossberg wrote: ...
6 years, 6 months ago (2014-06-03 14:16:35 UTC) #3
marja
6 years, 6 months ago (2014-06-03 15:02:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r21649 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698