Fix the race when the WebRtcAudioDeviceImpl goes away before capturers stop

Fix the race when the WebRtcAudioDeviceImpl goes away before capturers stop.
This is needed with some recent refactoring to separate media stream from peerconnection. And it will crash if the peerconnection goes away before media stream is stopped.

NOTRY=true
BUG=379856
TEST=cluster-fuzz bot, and local build with ASAN.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276600

[no longer working on chromium, 2014-06-03 10:58:07]

Henrik, please review.

Thanks,
SX

[henrika (OOO until Aug 14), 2014-06-03 11:00:15]

LGTM

https://codereview.chromium.org/310013002/diff/40001/content/renderer/media/w...
File content/renderer/media/webrtc/peer_connection_dependency_factory.cc
(right):

https://codereview.chromium.org/310013002/diff/40001/content/renderer/media/w...
content/renderer/media/webrtc/peer_connection_dependency_factory.cc:450: //
TODO(xians): Remove the following line of code after the APM in WebRTC is
Link to crbug?

https://codereview.chromium.org/310013002/diff/40001/content/renderer/media/w...
File content/renderer/media/webrtc_audio_device_impl.cc (right):

https://codereview.chromium.org/310013002/diff/40001/content/renderer/media/w...
content/renderer/media/webrtc_audio_device_impl.cc:253: // Cache the captures in
a local list since WebRtcAudioCapturer::Stop()
capturers

[no longer working on chromium, 2014-06-03 11:31:14]

landing soon.

Thanks.

https://codereview.chromium.org/310013002/diff/40001/content/renderer/media/w...
File content/renderer/media/webrtc/peer_connection_dependency_factory.cc
(right):

https://codereview.chromium.org/310013002/diff/40001/content/renderer/media/w...
content/renderer/media/webrtc/peer_connection_dependency_factory.cc:450: //
TODO(xians): Remove the following line of code after the APM in WebRTC is
On 2014/06/03 11:00:15, henrika wrote:
> Link to crbug?

Done.

https://codereview.chromium.org/310013002/diff/40001/content/renderer/media/w...
File content/renderer/media/webrtc_audio_device_impl.cc (right):

https://codereview.chromium.org/310013002/diff/40001/content/renderer/media/w...
content/renderer/media/webrtc_audio_device_impl.cc:253: // Cache the captures in
a local list since WebRtcAudioCapturer::Stop()
On 2014/06/03 11:00:15, henrika wrote:
> capturers

Done.

[no longer working on chromium, 2014-06-03 11:31:17]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-06-03 11:31:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/310013002/60001

[commit-bot: I haz the power, 2014-06-03 13:31:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-03 14:23:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-03 14:23:26]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[no longer working on chromium, 2014-06-04 12:24:51]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-06-04 12:27:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/310013002/80001

[commit-bot: I haz the power, 2014-06-04 15:54:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-04 17:06:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-04 17:06:45]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[no longer working on chromium, 2014-06-11 18:07:04]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-06-11 18:10:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/310013002/100001

[commit-bot: I haz the power, 2014-06-11 20:38:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 20:43:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 20:43:56]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[no longer working on chromium, 2014-06-12 07:17:41]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-06-12 07:22:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/310013002/100001

[no longer working on chromium, 2014-06-12 09:09:25]

The CQ bit was unchecked by xians@chromium.org

[no longer working on chromium, 2014-06-12 09:09:39]

The CQ bit was checked by xians@chromium.org

[commit-bot: I haz the power, 2014-06-12 09:13:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/xians@chromium.org/310013002/100001

[commit-bot: I haz the power, 2014-06-12 09:28:31]

Change committed as 276600