Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 310003004: Update tree walking to not update a list while iterating over it. (Closed)

Created:
6 years, 6 months ago by qsr
Modified:
6 years, 6 months ago
Reviewers:
bulach, brettw
CC:
chromium-reviews
Visibility:
Public.

Description

Update tree walking to not update a list while iterating over it. It is not correct, in python, to modify a list while iterating over it. TBR=bulach@chromium.org, brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M tools/checkdeps/java_checker.py View 1 chunk +17 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 6 months ago (2014-06-03 17:26:00 UTC) #1
qsr
This was TBR, as this is https://codereview.chromium.org/312703002/, but on the right repo
6 years, 6 months ago (2014-06-03 17:26:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/310003004/1
6 years, 6 months ago (2014-06-03 17:26:39 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 20:56:39 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 22:44:24 UTC) #5
Message was sent while issue was closed.
Change committed as 274660

Powered by Google App Engine
This is Rietveld 408576698