Make isEditablePosition to work with Position objects other than PositionIsOffsetInAnchor

Make isEditablePosition to work with Position objects other than PositionIsOffsetInAnchor

This patch makes isEditablePosition to work with Position objects other than
PositionIsOffsetInAnchor by using Position::parentAnchoredEquivalent() to
use right Node object for checking editability.

BUG=348973
TEST=LayoutTests/editing/execCommand/format-block-with-uneditable-crash.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175660

[yosin_UTC9, 2014-06-04 01:26:52]

Could you review this patch?
Thanks in advance.

Note: win_blink_rel bot failures aren't related to this patch.

[Yuta Kitamura, 2014-06-06 08:55:07]

LGTM with one simple comment

https://codereview.chromium.org/309993002/diff/20001/Source/core/editing/html...
File Source/core/editing/htmlediting.cpp (right):

https://codereview.chromium.org/309993002/diff/20001/Source/core/editing/html...
Source/core/editing/htmlediting.cpp:157: Node* node =
p.parentAnchoredEquivalent().deprecatedNode();
You should use anchorNode() instead of deprecatedNode(),
since we know it's parent-anchored.

[yosin_UTC9, 2014-06-06 09:26:11]

Thanks for reviewing!
Committing...

https://codereview.chromium.org/309993002/diff/20001/Source/core/editing/html...
File Source/core/editing/htmlediting.cpp (right):

https://codereview.chromium.org/309993002/diff/20001/Source/core/editing/html...
Source/core/editing/htmlediting.cpp:157: Node* node =
p.parentAnchoredEquivalent().deprecatedNode();
On 2014/06/06 08:55:07, Yuta Kitamura wrote:
> You should use anchorNode() instead of deprecatedNode(),
> since we know it's parent-anchored.

Done.

[yosin_UTC9, 2014-06-06 09:26:15]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2014-06-06 09:26:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yosin@chromium.org/309993002/40001

[commit-bot: I haz the power, 2014-06-06 10:37:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10960)

[commit-bot: I haz the power, 2014-06-06 11:20:29]

Change committed as 175660