Issue 309963003: Refactors GetDeviceIdentifier()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 309963003: Refactors GetDeviceIdentifier() (Closed)

Created:
6 years, 6 months ago by pkl (ping after 24h if needed)

Modified:
6 years, 6 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Refactors GetDeviceIdentifier() This refactors GetDeviceIdentifier function into GetDeviceIdentifier and GetSaltedString. GetSaltedString is a utility function that can be used elsewhere. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274520

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -2 lines)			Patch
M	base/ios/device_util.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	base/ios/device_util.mm	View	1 chunk	+10 lines, -2 lines	0 comments	Download
M	base/ios/device_util_unittest.mm	View	1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

LGTM Code looks fine, but GetSaltedString() doesn't really belong in device_util.h. Is there a better ...

6 years, 6 months ago (2014-06-03 11:43:05 UTC) #2

pkl (ping after 24h if needed)

The CQ bit was checked by pkl@chromium.org

6 years, 6 months ago (2014-06-03 11:53:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkl@chromium.org/309963003/1

6 years, 6 months ago (2014-06-03 11:56:20 UTC) #4

Message was sent while issue was closed.

Change committed as 274520

Expand Messages | Collapse Messages