Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 309933002: MSE: Complete removal of Blink-side support for LegacyFrameProcessor (Closed)

Created:
6 years, 6 months ago by wolenetz
Modified:
6 years, 5 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, jamesr, philipj_slow
Visibility:
Public.

Description

MSE: Complete removal of Blink-side support for LegacyFrameProcessor This is the last of a three-sided change to remove LegacyFrameProcessor from Blink and Chromium now that the new FrameProcessor is stabilized. R=acolwell@chromium.org,abarth@chromium.org BUG=249422 TEST=No MSE layout test regression locally on Linux Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177248

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase w.r.t. updated part 1 of three-sided change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -21 lines) Patch
M public/platform/WebMediaSource.h View 1 2 3 2 chunks +1 line, -21 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
wolenetz
PTAL @ PS1 acolwell@: everything abarth@: public/platform See part 1/3 (https://codereview.chromium.org/310733002/) for a description of ...
6 years, 6 months ago (2014-06-03 02:58:59 UTC) #1
wolenetz
PTAL @ PS2 (just a no-op rebase of PS1). Intent is to land this by ...
6 years, 6 months ago (2014-06-09 20:34:26 UTC) #2
acolwell GONE FROM CHROMIUM
lgtm
6 years, 6 months ago (2014-06-13 18:31:18 UTC) #3
wolenetz
Thanks for review. Landing this pends landing https://codereview.chromium.org/315483002/
6 years, 6 months ago (2014-06-16 20:02:35 UTC) #4
wolenetz
abarth@: ping
6 years, 6 months ago (2014-06-16 20:03:10 UTC) #5
wolenetz
On 2014/06/16 20:03:10, wolenetz wrote: > abarth@: ping I'll have an updated patch set shortly ...
6 years, 6 months ago (2014-06-16 20:50:00 UTC) #6
wolenetz
abarth@: PTAL @ patch set 4. Thank you!
6 years, 6 months ago (2014-06-16 20:51:09 UTC) #7
abarth-chromium
LGTM!
6 years, 6 months ago (2014-06-16 22:44:58 UTC) #8
wolenetz
Thank you for reviews. The first two parts of this three-sided change have now landed. ...
6 years, 6 months ago (2014-06-19 17:40:46 UTC) #9
wolenetz
The CQ bit was checked by wolenetz@chromium.org
6 years, 5 months ago (2014-06-30 20:23:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/309933002/60001
6 years, 5 months ago (2014-06-30 20:24:15 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 23:21:23 UTC) #12
Message was sent while issue was closed.
Change committed as 177248

Powered by Google App Engine
This is Rietveld 408576698