Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: ui/views/controls/native/native_view_host_wrapper.h

Issue 30993004: Reland: Implement features in NativeViewHostAura for scroll end effect (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing compile failure on the bots Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/native/native_view_host_win.cc ('k') | ui/views/controls/webview/webview.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/native/native_view_host_wrapper.h
diff --git a/ui/views/controls/native/native_view_host_wrapper.h b/ui/views/controls/native/native_view_host_wrapper.h
index 3b3cb37fbdc0b5382b8819ca7223a0b4f88b28fd..5958757aba2d0ab7b73015589796a6d0a5319fe3 100644
--- a/ui/views/controls/native/native_view_host_wrapper.h
+++ b/ui/views/controls/native/native_view_host_wrapper.h
@@ -19,10 +19,10 @@ class VIEWS_EXPORT NativeViewHostWrapper {
public:
virtual ~NativeViewHostWrapper() {}
- // Called right before a gfx::NativeView is attached to the associated
- // NativeViewHost, allowing the wrapper to perform platform-specific
- // initialization.
- virtual void NativeViewWillAttach() = 0;
+ // Called at the end of NativeViewHost::Attach, allowing the wrapper to
+ // perform platform-specific operations that need to occur to complete
+ // attaching the gfx::NativeView.
+ virtual void AttachNativeView() = 0;
// Called before the attached gfx::NativeView is detached from the
// NativeViewHost, allowing the wrapper to perform platform-specific
@@ -38,13 +38,18 @@ class VIEWS_EXPORT NativeViewHostWrapper {
// rooted at a valid Widget.
virtual void RemovedFromWidget() = 0;
- // Installs a clip on the gfx::NativeView.
+ // Installs a clip on the gfx::NativeView. These values are in the coordinate
+ // space of the gfx::NativeView, so if this method is called from ShowWidget
+ // then the values need to be translated.
virtual void InstallClip(int x, int y, int w, int h) = 0;
// Whether or not a clip has been installed on the wrapped gfx::NativeView.
virtual bool HasInstalledClip() = 0;
- // Removes the clip installed on the gfx::NativeView by way of InstallClip.
+ // Removes the clip installed on the gfx::NativeView by way of InstallClip. A
+ // following call to ShowWidget should occur after calling this method to
+ // position the gfx::NativeView correctly, since the clipping process may have
+ // adjusted its position.
virtual void UninstallClip() = 0;
// Shows the gfx::NativeView at the specified position (relative to the parent
« no previous file with comments | « ui/views/controls/native/native_view_host_win.cc ('k') | ui/views/controls/webview/webview.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698