Reland: Implement features in NativeViewHostAura for scroll end effect

chrome/browser/ui/views/find_bar_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/find_bar_host.h"
 
 #include <algorithm>
 
 #include "chrome/browser/ui/find_bar/find_bar_controller.h"
 #include "chrome/browser/ui/find_bar/find_tab_helper.h"
@@ skipping 22 matching lines @@
 }  // namespace chrome
 
 ////////////////////////////////////////////////////////////////////////////////
 // FindBarHost, public:
 
 FindBarHost::FindBarHost(BrowserView* browser_view)
     : DropdownBarHost(browser_view),
       find_bar_controller_(NULL) {
   FindBarView* find_bar_view = new FindBarView(this);
   Init(browser_view->find_bar_host_view(), find_bar_view, find_bar_view);
+  host()->StackAtTop();

[sky, 2013/10/22 19:57:32]

Why do we need a stack at top now? And this won't work on non-aura.

[rharrison, 2013/10/22 20:34:41]

The content/clipping layers are being painted on top of the find bar's widget
with my CL. Specifically the clipping/contents layer is appearing as a later
child of the browser frame layer now. I was thinking that since the find bar
cares about being on top that it should be enforcing its position explicitly. Do
you have any thoughts on how to better implement this or is the ordering of
these layers supposed to be enforced via a different mechanism and I should
investigate why it has changed?

[sky, 2013/10/22 21:32:19]

See kHostViewKey. I suspect you need to adjust stacking when reparenting.

[rharrison, 2013/10/24 14:40:15]

Done.

 }
 
 FindBarHost::~FindBarHost() {
 }
 
 bool FindBarHost::MaybeForwardKeyEventToWebpage(
     const ui::KeyEvent& key_event) {
   if (!ShouldForwardKeyEventToWebpageNative(key_event)) {
     // Native implementation says not to forward these events.
     return false;
@@ skipping 311 matching lines @@
 ////////////////////////////////////////////////////////////////////////////////
 // private:
 
 void FindBarHost::GetWidgetPositionNative(gfx::Rect* avoid_overlapping_rect) {
   gfx::Rect frame_rect = host()->GetTopLevelWidget()->GetWindowBoundsInScreen();
   content::WebContentsView* tab_view =
       find_bar_controller_->web_contents()->GetView();
   gfx::Rect webcontents_rect = tab_view->GetViewBounds();
   avoid_overlapping_rect->Offset(0, webcontents_rect.y() - frame_rect.y());
 }