content/renderer/media/rtc_media_constraints.cc - Issue 30983002: Switch from using internal constraints to use explicit PeerConnectionFactoryInterface::SetOptions t…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_media_constraints.cc

Issue 30983002: Switch from using internal constraints to use explicit PeerConnectionFactoryInterface::SetOptions t… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@track_stop

Patch Set: Addressed fishmans comment. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/media_stream_dependency_factory.cc ('K') | « content/renderer/media/media_stream_dependency_factory.cc ('k') | content/renderer/media/rtc_peer_connection_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/rtc_media_constraints.cc

diff --git a/content/renderer/media/rtc_media_constraints.cc b/content/renderer/media/rtc_media_constraints.cc

index 7fa9791f2ebbcd23db32b5a1118467cdd220943d..6f8ba558c8c18f8bc48ff40c5940acf6ecd2e67b 100644

--- a/content/renderer/media/rtc_media_constraints.cc

+++ b/content/renderer/media/rtc_media_constraints.cc

@@ -27,13 +27,6 @@ void GetNativeMediaConstraints(

new_constraint.key == kMediaStreamSourceId)

continue;

- // Ignore internal constraints set by JS.

Ami GONE FROM CHROMIUM 2013/10/23 21:33:11 Just to make sure: you're ok with internal constra

perkj_chrome 2013/11/01 09:12:54 All internal constraints are removed as far as I k

- // TODO(jiayl): replace the hard coded string with

- // webrtc::MediaConstraintsInterface::kInternalConstraintPrefix when

- // the Libjingle change is rolled.

- if (StartsWithASCII(new_constraint.key, "internal", true))

- continue;

DVLOG(3) << "MediaStreamConstraints:" << new_constraint.key

<< " : " << new_constraint.value;

native_constraints->push_back(new_constraint);