Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2382)

Unified Diff: content/renderer/media/rtc_media_constraints.cc

Issue 30983002: Switch from using internal constraints to use explicit PeerConnectionFactoryInterface::SetOptions t… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@track_stop
Patch Set: Addressed fishmans comments. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/rtc_media_constraints.cc
diff --git a/content/renderer/media/rtc_media_constraints.cc b/content/renderer/media/rtc_media_constraints.cc
index 7fa9791f2ebbcd23db32b5a1118467cdd220943d..06d6715a4f7a5a258e82086d5c7be53334c5c5d8 100644
--- a/content/renderer/media/rtc_media_constraints.cc
+++ b/content/renderer/media/rtc_media_constraints.cc
@@ -3,6 +3,8 @@
// found in the LICENSE file.
#include "content/renderer/media/rtc_media_constraints.h"
+#include <string>
+
#include "base/logging.h"
#include "base/strings/string_util.h"
#include "content/common/media/media_stream_options.h"
@@ -28,11 +30,12 @@ void GetNativeMediaConstraints(
continue;
// Ignore internal constraints set by JS.
- // TODO(jiayl): replace the hard coded string with
- // webrtc::MediaConstraintsInterface::kInternalConstraintPrefix when
- // the Libjingle change is rolled.
- if (StartsWithASCII(new_constraint.key, "internal", true))
+ if (StartsWithASCII(
+ new_constraint.key,
+ webrtc::MediaConstraintsInterface::kInternalConstraintPrefix,
+ true)) {
continue;
+ }
DVLOG(3) << "MediaStreamConstraints:" << new_constraint.key
<< " : " << new_constraint.value;
« no previous file with comments | « content/renderer/media/media_stream_dependency_factory.cc ('k') | content/renderer/media/rtc_peer_connection_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698