Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 30983002: Switch from using internal constraints to use explicit PeerConnectionFactoryInterface::SetOptions t… (Closed)

Created:
7 years, 2 months ago by perkj_chrome
Modified:
7 years, 1 month ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, Henrik Grunell
Base URL:
https://chromium.googlesource.com/chromium/src.git@track_stop
Visibility:
Public.

Description

Switch from using internal constraints to use explicit PeerConnectionFactoryInterface::SetOptions to set command line options on new PeerConnections. BUG=304024 R=fischman@chromium.org, jiayl@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232702

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed fishmans comment. #

Total comments: 10

Patch Set 3 : Addressed fishmans comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -45 lines) Patch
M content/renderer/media/media_stream_dependency_factory.cc View 1 2 2 chunks +39 lines, -35 lines 0 comments Download
M content/renderer/media/rtc_media_constraints.cc View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
perkj_chrome
7 years, 2 months ago (2013-10-20 16:02:47 UTC) #1
Ami GONE FROM CHROMIUM
<drive-by> https://codereview.chromium.org/30983002/diff/1/content/renderer/media/media_stream_dependency_factory.cc File content/renderer/media/media_stream_dependency_factory.cc (right): https://codereview.chromium.org/30983002/diff/1/content/renderer/media/media_stream_dependency_factory.cc#newcode563 content/renderer/media/media_stream_dependency_factory.cc:563: return pc_factory_.get() != NULL; Isn't this unconditionally true ...
7 years, 2 months ago (2013-10-20 20:32:11 UTC) #2
perkj_chrome
Addressed fishmans comment and rebased cl to latest. https://codereview.chromium.org/30983002/diff/1/content/renderer/media/media_stream_dependency_factory.cc File content/renderer/media/media_stream_dependency_factory.cc (right): https://codereview.chromium.org/30983002/diff/1/content/renderer/media/media_stream_dependency_factory.cc#newcode563 content/renderer/media/media_stream_dependency_factory.cc:563: return ...
7 years, 2 months ago (2013-10-21 09:56:57 UTC) #3
jiayl
lgtm, but you need an owner to review, e.g. fischman
7 years, 2 months ago (2013-10-23 16:40:51 UTC) #4
Ami GONE FROM CHROMIUM
LGTM % nits and clarifying question. https://codereview.chromium.org/30983002/diff/50001/content/renderer/media/media_stream_dependency_factory.cc File content/renderer/media/media_stream_dependency_factory.cc (right): https://codereview.chromium.org/30983002/diff/50001/content/renderer/media/media_stream_dependency_factory.cc#newcode513 content/renderer/media/media_stream_dependency_factory.cc:513: audio_device_ = new ...
7 years, 2 months ago (2013-10-23 21:33:11 UTC) #5
perkj_chrome
https://codereview.chromium.org/30983002/diff/50001/content/renderer/media/media_stream_dependency_factory.cc File content/renderer/media/media_stream_dependency_factory.cc (right): https://codereview.chromium.org/30983002/diff/50001/content/renderer/media/media_stream_dependency_factory.cc#newcode513 content/renderer/media/media_stream_dependency_factory.cc:513: audio_device_ = new WebRtcAudioDeviceImpl(); On 2013/10/23 21:33:11, Ami Fischman ...
7 years, 1 month ago (2013-11-01 09:12:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/30983002/130001
7 years, 1 month ago (2013-11-01 09:13:25 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-01 10:02:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/30983002/130001
7 years, 1 month ago (2013-11-01 11:57:22 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests, content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217357
7 years, 1 month ago (2013-11-01 15:28:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/30983002/130001
7 years, 1 month ago (2013-11-01 19:10:50 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217650
7 years, 1 month ago (2013-11-01 22:31:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/30983002/130001
7 years, 1 month ago (2013-11-02 06:18:07 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=218069
7 years, 1 month ago (2013-11-02 09:27:31 UTC) #14
perkj_chrome
7 years, 1 month ago (2013-11-04 12:35:38 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 manually as r232702 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698