Issue 309823004: Try TSAN blacklist for SkGLContextHelper::init.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 309823004: Try TSAN blacklist for SkGLContextHelper::init. (Closed)

Created:
6 years, 6 months ago by mtklein_C

Modified:
6 years, 6 months ago

Reviewers:
mtklein

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Try TSAN blacklist for SkGLContextHelper::init. Submitting to test this; this particular problem only happens on the bot. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ab2ec19b975a898d4ee2278ddad7d4268f134478

Patch Set 1 #

Patch Set 2 : fix path #

Patch Set 3 : remove #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -8 lines)			Patch
M	gyp/common_conditions.gypi	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	tools/tsan.blacklist	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	tools/tsan.supp	View	1 2	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/309823004/40001

6 years, 6 months ago (2014-06-03 02:06:01 UTC) #2

commit-bot: I haz the power

Change committed as ab2ec19b975a898d4ee2278ddad7d4268f134478

6 years, 6 months ago (2014-06-03 02:11:10 UTC) #3

mtklein

6 years, 6 months ago (2014-06-03 02:33:49 UTC) #4

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/314543002/ by mtklein@google.com.

The reason for reverting is: the bot's clang doesn't know -fsanitize-blacklist.

Expand Messages | Collapse Messages