Pass ui::LatencyInfo correct with unified gesture detector on Aura.

Pass ui::LatencyInfo correct with unified gesture detector on Aura.

BUG=379812
TEST=GestureRecognizerTest.LatencyPassedFromTouchEvent

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274602

[tdresser, 2014-06-02 17:17:58]

jdduke@, can you take a look at ui/events?

sadrul@, can you take a look at 
ui/aura/gestures/gesture_recognizer_unittest.cc

[jdduke (slow), 2014-06-02 17:27:24]

lgtm, Yufeng, this is what we need, right?

https://codereview.chromium.org/309823002/diff/20001/ui/events/gestures/gestu...
File ui/events/gestures/gesture_provider_aura.cc (right):

https://codereview.chromium.org/309823002/diff/20001/ui/events/gestures/gestu...
ui/events/gestures/gesture_provider_aura.cc:24: last_touch_event_flags_ =
event.flags();
Hmm, should we move these |last_foo_ = event.foo()| assignments below the checks
where we might early return false?

[tdresser, 2014-06-02 17:33:23]

https://codereview.chromium.org/309823002/diff/20001/ui/events/gestures/gestu...
File ui/events/gestures/gesture_provider_aura.cc (right):

https://codereview.chromium.org/309823002/diff/20001/ui/events/gestures/gestu...
ui/events/gestures/gesture_provider_aura.cc:24: last_touch_event_flags_ =
event.flags();
On 2014/06/02 17:27:24, jdduke wrote:
> Hmm, should we move these |last_foo_ = event.foo()| assignments below the
checks
> where we might early return false?

Done.

[Yufeng Shen (Slow to review), 2014-06-02 18:27:03]

https://codereview.chromium.org/309823002/diff/1/ui/events/gestures/gesture_p...
File ui/events/gestures/gesture_provider_aura.cc (right):

https://codereview.chromium.org/309823002/diff/1/ui/events/gestures/gesture_p...
ui/events/gestures/gesture_provider_aura.cc:87: last_touch_event_latency_info_,
so is it guaranteed that the this gesture is derived from the last_touch_event ?

[tdresser, 2014-06-02 18:30:04]

https://codereview.chromium.org/309823002/diff/1/ui/events/gestures/gesture_p...
File ui/events/gestures/gesture_provider_aura.cc (right):

https://codereview.chromium.org/309823002/diff/1/ui/events/gestures/gesture_p...
ui/events/gestures/gesture_provider_aura.cc:87: last_touch_event_latency_info_,
On 2014/06/02 18:27:04, Yufeng Shen wrote:
> so is it guaranteed that the this gesture is derived from the last_touch_event
?

Yes, although this would attribute a gesture fired on a timer to the most recent
touch, which may or may not be what we want.

[Yufeng Shen (Slow to review), 2014-06-02 18:43:34]

https://codereview.chromium.org/309823002/diff/1/ui/events/gestures/gesture_p...
File ui/events/gestures/gesture_provider_aura.cc (right):

https://codereview.chromium.org/309823002/diff/1/ui/events/gestures/gesture_p...
ui/events/gestures/gesture_provider_aura.cc:87: last_touch_event_latency_info_,
On 2014/06/02 18:30:04, tdresser wrote:
> On 2014/06/02 18:27:04, Yufeng Shen wrote:
> > so is it guaranteed that the this gesture is derived from the
last_touch_event
> ?
> 
> Yes, although this would attribute a gesture fired on a timer to the most
recent
> touch, which may or may not be what we want.

Is it easy to add some latency components to the gesture that is fired on timer
using the timestamp of the timer, e.g. the ui::INPUT_EVENT_LATENCY_UI_COMPONENT
component, and here we check only if we don't have the UI component then we copy
the latency from last_touch_event ?

[tdresser, 2014-06-02 20:04:10]

https://codereview.chromium.org/309823002/diff/1/ui/events/gestures/gesture_p...
File ui/events/gestures/gesture_provider_aura.cc (right):

https://codereview.chromium.org/309823002/diff/1/ui/events/gestures/gesture_p...
ui/events/gestures/gesture_provider_aura.cc:87: last_touch_event_latency_info_,
On 2014/06/02 18:43:35, Yufeng Shen wrote:
> On 2014/06/02 18:30:04, tdresser wrote:
> > On 2014/06/02 18:27:04, Yufeng Shen wrote:
> > > so is it guaranteed that the this gesture is derived from the
> last_touch_event
> > ?
> > 
> > Yes, although this would attribute a gesture fired on a timer to the most
> recent
> > touch, which may or may not be what we want.
> 
> Is it easy to add some latency components to the gesture that is fired on
timer
> using the timestamp of the timer, e.g. the
ui::INPUT_EVENT_LATENCY_UI_COMPONENT
> component, and here we check only if we don't have the UI component then we
copy
> the latency from last_touch_event ?
> 

I've gone with the existing Aura behavior, which is to not set any latency
components for events triggered by a timeout.

[Yufeng Shen (Slow to review), 2014-06-02 20:19:44]

On 2014/06/02 20:04:10, tdresser wrote:
>
https://codereview.chromium.org/309823002/diff/1/ui/events/gestures/gesture_p...
> File ui/events/gestures/gesture_provider_aura.cc (right):
> 
>
https://codereview.chromium.org/309823002/diff/1/ui/events/gestures/gesture_p...
> ui/events/gestures/gesture_provider_aura.cc:87:
last_touch_event_latency_info_,
> On 2014/06/02 18:43:35, Yufeng Shen wrote:
> > On 2014/06/02 18:30:04, tdresser wrote:
> > > On 2014/06/02 18:27:04, Yufeng Shen wrote:
> > > > so is it guaranteed that the this gesture is derived from the
> > last_touch_event
> > > ?
> > > 
> > > Yes, although this would attribute a gesture fired on a timer to the most
> > recent
> > > touch, which may or may not be what we want.
> > 
> > Is it easy to add some latency components to the gesture that is fired on
> timer
> > using the timestamp of the timer, e.g. the
> ui::INPUT_EVENT_LATENCY_UI_COMPONENT
> > component, and here we check only if we don't have the UI component then we
> copy
> > the latency from last_touch_event ?
> > 
> 
> I've gone with the existing Aura behavior, which is to not set any latency
> components for events triggered by a timeout.

lgtm

[sadrul, 2014-06-02 20:58:23]

rslgtm

[tdresser, 2014-06-02 20:59:28]

The CQ bit was checked by tdresser@chromium.org

[commit-bot: I haz the power, 2014-06-02 21:02:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdresser@chromium.org/309823002/80001

[commit-bot: I haz the power, 2014-06-02 22:30:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/11914)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/15004)

[commit-bot: I haz the power, 2014-06-02 22:37:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-02 22:37:22]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[tdresser, 2014-06-03 12:23:55]

The CQ bit was checked by tdresser@chromium.org

[commit-bot: I haz the power, 2014-06-03 12:24:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdresser@chromium.org/309823002/100001

[tdresser, 2014-06-03 14:26:13]

The CQ bit was checked by tdresser@chromium.org

[commit-bot: I haz the power, 2014-06-03 14:27:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tdresser@chromium.org/309823002/120001

[commit-bot: I haz the power, 2014-06-03 18:00:37]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-03 20:18:19]

Change committed as 274602