Issue 309793006: Call Start() from NetMetricsLogUploader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 309793006: Call Start() from NetMetricsLogUploader. (Closed)

Created:
6 years, 6 months ago by Alexei Svitkine (slow)

Modified:
6 years, 6 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Call Start() from NetMetricsLogUploader. Before the CL that introduced NetMetricsLogUploader, Start() was being called from MetricsService::SendStagedLog(). However, it got lost in the refactoring. This re-adds it. BUG=375771 R=isherman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274306

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	components/metrics/net/net_metrics_log_uploader.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Alexei Svitkine (slow)

The CQ bit was checked by asvitkine@chromium.org

6 years, 6 months ago (2014-06-02 19:05:28 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/309793006/1

6 years, 6 months ago (2014-06-02 19:06:20 UTC) #3

Alexei Svitkine (slow)

6 years, 6 months ago (2014-06-02 19:28:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r274306 (presubmit successful).