Fixing problem with edge swipe exiting immersive mode

ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc

Index: ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
diff --git a/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc b/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
index 5a7c9b17bd7aa784c80dd13038641d4074d95b22..6657243255f8af82fc1238c665b8281dff06c513 100644
--- a/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
+++ b/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
@@ -1155,6 +1155,69 @@ TEST_F(MaximizeModeWindowManagerTest, ExitFullScreenWithEdgeTouchAtBottom) {
   DestroyMaximizeModeWindowManager();
 }
 
+// Test that an edge swipe from the top on an immersive mode window will not end
+// full screen mode.
+TEST_F(MaximizeModeWindowManagerTest, NoExitImmersiveModeWithEdgeSwipeFromTop) {
+  scoped_ptr<aura::Window> window(CreateWindow(ui::wm::WINDOW_TYPE_NORMAL,
+                                  gfx::Rect(10, 10, 200, 50)));
+  wm::WindowState* window_state = wm::GetWindowState(window.get());
+  wm::ActivateWindow(window.get());
+  CreateMaximizeModeWindowManager();
+
+  // Fullscreen the window.
+  wm::WMEvent event(wm::WM_EVENT_TOGGLE_FULLSCREEN);
+  window_state->OnWMEvent(&event);
+  EXPECT_TRUE(window_state->IsFullscreen());
+  EXPECT_FALSE(window_state->in_immersive_fullscreen());

[pkotwicz, 2014/06/02 22:27:58]

For the sake of the record (in case someone looks at old codereviews and wonders
whether this test makes a statement about immersive fullscreen behavior) I do
not particularly like the assertion on line 1171. For any CrOS window firing
wm::WM_EVENT_TOGGLE_FULLSCREEN should enter immersive fullscreen. This test
works because we use an aura::Window with no associated widget and no associated
ash::CustomFrameViewAsh. (I think the test is fine though)

Shouldn't this test call WindowState::set_in_immersive_fullscreen() somewhere? -
I checked and this test does fail.

[Mr4D (OOO till 08-26), 2014/06/03 14:36:40]

Aaargh. I am not sure where the activation line went (it is in the other test
below line 1203). Done.

+  EXPECT_EQ(window.get(), wm::GetActiveWindow());
+
+  // Do an edge swipe top into screen.
+  aura::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
+  generator.GestureScrollSequence(gfx::Point(50, 0),
+                                  gfx::Point(50, 100),
+                                  base::TimeDelta::FromMilliseconds(20),
+                                  10);
+
+  // It should have not exited full screen or immersive mode.
+  EXPECT_TRUE(window_state->IsFullscreen());
+  EXPECT_TRUE(window_state->in_immersive_fullscreen());
+
+  DestroyMaximizeModeWindowManager();
+}
+
+// Test that an edge swipe from the bottom will not end immersive mode.
+TEST_F(MaximizeModeWindowManagerTest,
+       NoExitImmersiveModeWithEdgeSwipeFromBottom) {
+  scoped_ptr<aura::Window> window(CreateWindow(ui::wm::WINDOW_TYPE_NORMAL,
+                                               gfx::Rect(10, 10, 200, 50)));
+  wm::WindowState* window_state = wm::GetWindowState(window.get());
+  wm::ActivateWindow(window.get());
+  CreateMaximizeModeWindowManager();
+
+  // Fullscreen the window.
+  wm::WMEvent event(wm::WM_EVENT_TOGGLE_FULLSCREEN);
+  window_state->OnWMEvent(&event);
+  EXPECT_TRUE(window_state->IsFullscreen());
+  EXPECT_FALSE(window_state->in_immersive_fullscreen());
+  EXPECT_EQ(window.get(), wm::GetActiveWindow());
+  window_state->set_in_immersive_fullscreen(true);
+  EXPECT_TRUE(window_state->in_immersive_fullscreen());
+
+  // Do an edge swipe bottom into screen.
+  aura::test::EventGenerator generator(Shell::GetPrimaryRootWindow());
+  int y = Shell::GetPrimaryRootWindow()->bounds().bottom();
+  generator.GestureScrollSequence(gfx::Point(50, y),
+                                  gfx::Point(50, y - 100),
+                                  base::TimeDelta::FromMilliseconds(20),
+                                  10);
+
+  // The window should still be full screen and immersive.
+  EXPECT_TRUE(window_state->IsFullscreen());
+  EXPECT_TRUE(window_state->in_immersive_fullscreen());
+
+  DestroyMaximizeModeWindowManager();
+}
+
 #endif  // OS_WIN
 
 }  // namespace ash