Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2378)

Unified Diff: ash/wm/immersive_fullscreen_controller.cc

Issue 309793005: Fixing problem with edge swipe exiting immersive mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/immersive_fullscreen_controller.cc
diff --git a/ash/wm/immersive_fullscreen_controller.cc b/ash/wm/immersive_fullscreen_controller.cc
index b5df4b1062d5ccac5db29284840d95e0bc090da6..23d8874b526ef494abd2f5a8cbfdf074e9dafcc3 100644
--- a/ash/wm/immersive_fullscreen_controller.cc
+++ b/ash/wm/immersive_fullscreen_controller.cc
@@ -274,10 +274,15 @@ void ImmersiveFullscreenController::SetEnabled(WindowType window_type,
EnableWindowObservers(enabled_);
+ ash::wm::WindowState* window_state = wm::GetWindowState(native_window_);
// Auto hide the shelf in immersive fullscreen instead of hiding it.
- wm::GetWindowState(native_window_)->set_hide_shelf_when_fullscreen(!enabled);
+ window_state->set_hide_shelf_when_fullscreen(!enabled);
Shell::GetInstance()->UpdateShelfVisibility();
+ // Mark a browser window as an immersive mode window so that the
pkotwicz 2014/06/02 22:27:58 Can you please update this comment? Can this be c
Mr4D (OOO till 08-26) 2014/06/03 14:36:40 Done.
+ // window manager can treat it accordingly.
+ window_state->set_in_immersive_fullscreen(enabled);
+
if (enabled_) {
// Animate enabling immersive mode by sliding out the top-of-window views.
// No animation occurs if a lock is holding the top-of-window views open.
« no previous file with comments | « no previous file | ash/wm/immersive_fullscreen_controller_unittest.cc » ('j') | ash/wm/immersive_fullscreen_controller_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698