Fixing problem with edge swipe exiting immersive mode

chrome/browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/immersive_mode_controller_ash.h"
 
 #include "ash/ash_switches.h"
 #include "ash/root_window_controller.h"
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shelf/shelf_types.h"
 #include "ash/shell.h"
 #include "ash/test/ash_test_base.h"
+#include "ash/wm/window_state.h"
 #include "base/command_line.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/fullscreen/fullscreen_controller.h"
 #include "chrome/browser/ui/fullscreen/fullscreen_controller_test.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/frame/test_with_browser_view.h"
 #include "chrome/browser/ui/views/frame/top_container_view.h"
 #include "chrome/browser/ui/views/tabs/tab_strip.h"
 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
@@ skipping 232 matching lines @@
   // 3) Test that exiting tab fullscreen and immersive fullscreen
   // simultaneously correctly updates the shelf visibility and whether the tab
   // indicators should be hidden.
   SetTabFullscreen(true);
   ToggleFullscreen();
   ASSERT_FALSE(controller()->IsEnabled());
   EXPECT_EQ(ash::SHELF_VISIBLE, shelf->visibility_state());
   EXPECT_TRUE(controller()->ShouldHideTabIndicators());
 }
 
+// Check that the window state of a browser window gets properly marked for
+// immersive mode.

[pkotwicz, 2014/06/02 22:27:58]

I don't think this test is useful. ImmersiveModeController is a thin wrapper
around ash::ImmersiveFullscreenController

[Mr4D (OOO till 08-26), 2014/06/03 14:36:40]

Yes, it is now - and if someone changes that it might not test what we want
anymore. This was the reason why I left it here on purpose. If you strongly feel
otherwise I'll remove it.

[pkotwicz, 2014/06/03 15:15:02]

You could theoretically make that argument for duplicating all of the tests in
immersive_fullscreen_controller_unittest.cc in
immersive_mode_controller_ash_unittest.cc

If someone changes the relationship between ImmersiveFullscreenController and
ImmersiveModeController they will need to appropriately update the tests.

+TEST_F(ImmersiveModeControllerAshTest, WindowStateImmersiveModeFullscreen) {
+  AddTab(browser(), GURL("about:blank"));
+
+  ash::wm::WindowState* window_state =
+      ash::wm::GetWindowState(browser()->window()->GetNativeWindow());
+
+  EXPECT_FALSE(window_state->in_immersive_fullscreen());
+  ToggleFullscreen();
+  ASSERT_TRUE(controller()->IsEnabled());
+  EXPECT_TRUE(window_state->in_immersive_fullscreen());
+
+  ToggleFullscreen();
+  ASSERT_FALSE(controller()->IsEnabled());
+  EXPECT_FALSE(window_state->in_immersive_fullscreen());
+}
+
 class ImmersiveModeControllerAshTestHostedApp
     : public ImmersiveModeControllerAshTest {
  public:
   ImmersiveModeControllerAshTestHostedApp()
       : ImmersiveModeControllerAshTest(Browser::TYPE_POPUP,
                                        chrome::HOST_DESKTOP_TYPE_ASH,
                                        true) {
   }
   virtual ~ImmersiveModeControllerAshTestHostedApp() {}
 
@@ skipping 54 matching lines @@
 
   // Exit immersive fullscreen. The web contents should be back below the window
   // header.
   ToggleFullscreen();
   EXPECT_FALSE(browser_view()->GetWidget()->IsFullscreen());
   EXPECT_FALSE(controller()->IsEnabled());
   EXPECT_FALSE(tabstrip->visible());
   EXPECT_FALSE(toolbar->visible());
   EXPECT_EQ(header_height, GetBoundsInWidget(contents_web_view).y());
 }