Fixing problem with edge swipe exiting immersive mode

ash/wm/window_state.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_WINDOW_STATE_H_
 #define ASH_WM_WINDOW_STATE_H_
 
 #include "ash/ash_export.h"
 #include "ash/wm/drag_details.h"
 #include "ash/wm/wm_types.h"
@@ skipping 249 matching lines @@
 
   // True if this window has requested that the top-row keys (back, forward,
   // brightness, volume) should be treated as function keys.
   bool top_row_keys_are_function_keys() const {
     return top_row_keys_are_function_keys_;
   }
   void set_top_row_keys_are_function_keys(bool value) {
     top_row_keys_are_function_keys_ = value;
   }
 
+  // True if the window is in "immersive full screen mode" which is slightly
+  // different from the normal fullscreen mode by allowing the user to reveal
+  // the top portion of the window through a touch / mouse gesture. It will also
+  // allow the shelf to be shown.

[pkotwicz, 2014/06/02 22:27:58]

The part about "It will also allow the shelf to be shown" is not necessarily
true.

It is untrue if a window is in both immersive fullscreen and HTML 5 fullscreen.

[Mr4D (OOO till 08-26), 2014/06/03 14:36:40]

I am not sure if the full immersive functionality should be explained here. As
such I tried to keep this as brief as possible from the beginning. If someone is
interested in the full and actual state of immersive fullscreen he/she should
look at the explanations there. This is especially true since functionality
changes and a duplication of comments is dangerous like a duplication of code.
(I doubt that this comment would be updated). Nevertheless - I changed the
comment slightly again keeping it vague.

+  bool in_immersive_fullscreen() const {
+    return in_immersive_fullscreen_;
+  }
+  void set_in_immersive_fullscreen(bool enable) {
+    in_immersive_fullscreen_ = enable;
+  }
+
   // Creates and takes ownership of a pointer to DragDetails when resizing is
   // active. This should be done before a resizer gets created.
   void CreateDragDetails(aura::Window* window,
                          const gfx::Point& point_in_parent,
                          int window_component,
                          aura::client::WindowMoveSource source);
 
   // Deletes and clears a pointer to DragDetails. This should be done when the
   // resizer gets destroyed.
   void DeleteDragDetails();
@@ skipping 52 matching lines @@
   // The owner of this window settings.
   aura::Window* window_;
   scoped_ptr<WindowStateDelegate> delegate_;
 
   bool window_position_managed_;
   bool bounds_changed_by_user_;
   bool panel_attached_;
   bool ignored_by_shelf_;
   bool can_consume_system_keys_;
   bool top_row_keys_are_function_keys_;
+  bool in_immersive_fullscreen_;
   scoped_ptr<DragDetails> drag_details_;
 
   bool unminimize_to_restore_bounds_;
   bool hide_shelf_when_fullscreen_;

[pkotwicz, 2014/06/02 22:27:58]

Nit: Might as well group the fullscreen related properties together.

[Mr4D (OOO till 08-26), 2014/06/03 14:36:40]

Done.

   bool minimum_visibility_;
   bool can_be_dragged_;
 
   // A property to remember the window position which was set before the
   // auto window position manager changed the window bounds, so that it can get
   // restored when only this one window gets shown.
   scoped_ptr<gfx::Rect> pre_auto_manage_window_bounds_;
 
   ObserverList<WindowStateObserver> observer_list_;
 
@@ skipping 15 matching lines @@
 ASH_EXPORT WindowState* GetWindowState(aura::Window* window);
 
 // const version of GetWindowState.
 ASH_EXPORT const WindowState*
 GetWindowState(const aura::Window* window);
 
 }  // namespace wm
 }  // namespace ash
 
 #endif  // ASH_WM_WINDOW_STATE_H_