Fixing problem with edge swipe exiting immersive mode

ash/wm/window_state.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_WINDOW_STATE_H_
 #define ASH_WM_WINDOW_STATE_H_
 
 #include "ash/ash_export.h"
 #include "ash/wm/drag_details.h"
 #include "ash/wm/wm_types.h"
@@ skipping 249 matching lines @@
 
   // True if this window has requested that the top-row keys (back, forward,
   // brightness, volume) should be treated as function keys.
   bool top_row_keys_are_function_keys() const {
     return top_row_keys_are_function_keys_;
   }
   void set_top_row_keys_are_function_keys(bool value) {
     top_row_keys_are_function_keys_ = value;
   }
 
+  // True if the window is in immersive full screen mode which is slightly
+  // different than normal fullscreen mode (e.g. use of edge swipe gestures).
+  bool immersive_mode() const {

[pkotwicz, 2014/06/02 19:50:06]

This should be called in_immersive_fullscreen().

You should also include a warning that hide_shelf_when_fullscreen() is probably
what the person is looking for and a short description of what immersive
fullscreen is.
In particular:
- Immersive fullscreen does not imply that the shelf is auto hidden. The shelf
may be hidden completely and it may not be possible to reveal the shelf using
either the mouse or touch while in immersive fullscreen
- Any window can be put into immersive fullscreen (It is possible to put the
task manager into immersive fullscreen)
- Immersive fullscreen implies that the top non client frame views are
revealable. The top non client frame views may or may not steal a few pixels
from the top edge of the screen

[Mr4D (OOO till 08-26), 2014/06/02 20:36:20]

Done.

+    return immersive_mode_;
+  }
+  void set_immersive_mode(bool enable) {
+    immersive_mode_ = enable;
+  }
+
   // Creates and takes ownership of a pointer to DragDetails when resizing is
   // active. This should be done before a resizer gets created.
   void CreateDragDetails(aura::Window* window,
                          const gfx::Point& point_in_parent,
                          int window_component,
                          aura::client::WindowMoveSource source);
 
   // Deletes and clears a pointer to DragDetails. This should be done when the
   // resizer gets destroyed.
   void DeleteDragDetails();
@@ skipping 52 matching lines @@
   // The owner of this window settings.
   aura::Window* window_;
   scoped_ptr<WindowStateDelegate> delegate_;
 
   bool window_position_managed_;
   bool bounds_changed_by_user_;
   bool panel_attached_;
   bool ignored_by_shelf_;
   bool can_consume_system_keys_;
   bool top_row_keys_are_function_keys_;
+  bool immersive_mode_;
   scoped_ptr<DragDetails> drag_details_;
 
   bool unminimize_to_restore_bounds_;
   bool hide_shelf_when_fullscreen_;
   bool minimum_visibility_;
   bool can_be_dragged_;
 
   // A property to remember the window position which was set before the
   // auto window position manager changed the window bounds, so that it can get
   // restored when only this one window gets shown.
@@ skipping 19 matching lines @@
 ASH_EXPORT WindowState* GetWindowState(aura::Window* window);
 
 // const version of GetWindowState.
 ASH_EXPORT const WindowState*
 GetWindowState(const aura::Window* window);
 
 }  // namespace wm
 }  // namespace ash
 
 #endif  // ASH_WM_WINDOW_STATE_H_