Source/bindings/scripts/generate_event_interfaces.py - Issue 309793002: IDL build: Split global objects computation from global constructors computation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/generate_event_interfaces.py

Issue 309793002: IDL build: Split global objects computation from global constructors computation (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Tweak Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/compute_global_objects.py ('K') | « Source/bindings/scripts/compute_interfaces_info_individual.py ('k') | Source/bindings/scripts/generate_global_constructors.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/scripts/generate_event_interfaces.py

diff --git a/Source/bindings/scripts/generate_event_interfaces.py b/Source/bindings/scripts/generate_event_interfaces.py

index 92abe426b11e9bd541a77e74c89cafea8ec38d27..b222cb4a64b359785a3b247fa58985ecd1a423e0 100755

--- a/Source/bindings/scripts/generate_event_interfaces.py

+++ b/Source/bindings/scripts/generate_event_interfaces.py

@@ -45,7 +45,7 @@ import os

import posixpath

import sys

-from utilities import get_file_contents, write_file, get_interface_extended_attributes_from_idl

+from utilities import get_file_contents, read_file_to_list, write_file, get_interface_extended_attributes_from_idl

EXPORTED_EXTENDED_ATTRIBUTES = (

'Conditional',

@@ -111,8 +111,7 @@ def write_event_interfaces_file(event_idl_files, destination_filename, only_if_c

def main():

options = parse_options()

- with open(options.event_idl_files_list) as event_idl_files_list:

- event_idl_files = [line.rstrip('\n') for line in event_idl_files_list]

+ event_idl_files = read_file_to_list(options.event_idl_files_list)

write_event_interfaces_file(event_idl_files,

options.event_interfaces_file,

options.write_file_only_if_changed,