Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js

Issue 309783002: Exclude test types that don't upload from the flakiness dashboard UI. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments. update test Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (C) 2011 Google Inc. All rights reserved. 1 // Copyright (C) 2011 Google Inc. All rights reserved.
2 // 2 //
3 // Redistribution and use in source and binary forms, with or without 3 // Redistribution and use in source and binary forms, with or without
4 // modification, are permitted provided that the following conditions are 4 // modification, are permitted provided that the following conditions are
5 // met: 5 // met:
6 // 6 //
7 // * Redistributions of source code must retain the above copyright 7 // * Redistributions of source code must retain the above copyright
8 // notice, this list of conditions and the following disclaimer. 8 // notice, this list of conditions and the following disclaimer.
9 // * Redistributions in binary form must reproduce the above 9 // * Redistributions in binary form must reproduce the above
10 // copyright notice, this list of conditions and the following disclaimer 10 // copyright notice, this list of conditions and the following disclaimer
(...skipping 25 matching lines...) Expand all
36 g_allTestsTrie = null; 36 g_allTestsTrie = null;
37 var historyInstance = new history.History(flakinessConfig); 37 var historyInstance = new history.History(flakinessConfig);
38 // FIXME(jparent): Remove this once global isn't used. 38 // FIXME(jparent): Remove this once global isn't used.
39 g_history = historyInstance; 39 g_history = historyInstance;
40 g_testToResultsMap = {}; 40 g_testToResultsMap = {};
41 41
42 for (var key in history.DEFAULT_CROSS_DASHBOARD_STATE_VALUES) 42 for (var key in history.DEFAULT_CROSS_DASHBOARD_STATE_VALUES)
43 historyInstance.crossDashboardState[key] = history.DEFAULT_CROSS_DASHBOA RD_STATE_VALUES[key]; 43 historyInstance.crossDashboardState[key] = history.DEFAULT_CROSS_DASHBOA RD_STATE_VALUES[key];
44 44
45 LOAD_BUILDBOT_DATA({ 45 LOAD_BUILDBOT_DATA({
46 "no_upload_test_types": [
47 "webkit_unit_tests"
48 ],
46 'masters': [{ 49 'masters': [{
47 name: 'ChromiumWebkit', 50 name: 'ChromiumWebkit',
48 url: 'dummyurl', 51 url: 'dummyurl',
49 tests: { 52 tests: {
50 'layout-tests': {'builders': ['WebKit Linux', 'WebKit Linux (dbg )', 'WebKit Linux (deps)', 'WebKit Mac10.7', 'WebKit Win', 'WebKit Win (dbg)']}, 53 'layout-tests': {'builders': ['WebKit Linux', 'WebKit Linux (dbg )', 'WebKit Linux (deps)', 'WebKit Mac10.7', 'WebKit Win', 'WebKit Win (dbg)']},
51 'unit_tests': {'builders': ['Linux Tests']}, 54 'unit_tests': {'builders': ['Linux Tests']},
52 }, 55 },
53 groups: ['@ToT Chromium', '@ToT Blink'], 56 groups: ['@ToT Chromium', '@ToT Blink'],
54 },{ 57 },{
55 name :'ChromiumWin', 58 name :'ChromiumWin',
(...skipping 334 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 test.isFlaky = true; 393 test.isFlaky = true;
391 equal(shouldShowTest(test), false, 'hide flaky tests by default'); 394 equal(shouldShowTest(test), false, 'hide flaky tests by default');
392 historyInstance.dashboardSpecificState.showFlaky = true; 395 historyInstance.dashboardSpecificState.showFlaky = true;
393 equal(shouldShowTest(test), true, 'show flaky test'); 396 equal(shouldShowTest(test), true, 'show flaky test');
394 historyInstance.dashboardSpecificState.showFlaky = false; 397 historyInstance.dashboardSpecificState.showFlaky = false;
395 398
396 test = createResultsObjectForTest('foo/test.html', 'dummyBuilder'); 399 test = createResultsObjectForTest('foo/test.html', 'dummyBuilder');
397 historyInstance.crossDashboardState.testType = 'not layout tests'; 400 historyInstance.crossDashboardState.testType = 'not layout tests';
398 equal(shouldShowTest(test), true, 'show all non layout tests'); 401 equal(shouldShowTest(test), true, 'show all non layout tests');
399 }); 402 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698