Exclude test types that don't upload from the flakiness dashboard UI.

Tools/TestResultServer/static-dashboards/builders.js

 // Copyright (C) 2012 Google Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //    * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //    * Redistributions in binary form must reproduce the above
 // copyright notice, this list of conditions and the following disclaimer
@@ skipping 13 matching lines @@
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 function LOAD_BUILDBOT_DATA(builderData)
 {
     builders.masters = {};
     var groups = {};
     var testTypes = {};
+    var testTypesThatDoNotUpload = {};
+    builders.noUploadTestTypes = builderData['no_upload_test_types']
     builderData['masters'].forEach(function(master) {
         builders.masters[master.name] = new builders.BuilderMaster(master.name, master.url, master.tests, master.groups);
 
         master.groups.forEach(function(group) { groups[group] = true; });
 
         Object.keys(master.tests).forEach(function(testType) {
             if (builders.testTypeUploadsToFlakinessDashboardServer(testType))
                 testTypes[testType] = true;
+            else
+                testTypesThatDoNotUpload[testType] = true;
         });
     });
     builders.groups = Object.keys(groups);
     builders.groups.sort();
     builders.testTypes = Object.keys(testTypes);
     builders.testTypes.sort();
+    // FIXME: Expose this in the flakiness dashboard UI and give a clear error message
+    // pointing to a bug about getting the test type in question uploading results.
+    builders.testTypesThatDoNotUpload = Object.keys(testTypesThatDoNotUpload);
+    builders.testTypesThatDoNotUpload.sort();
 }
 
 var builders = builders || {};
 
 (function() {
 
 builders.testTypeUploadsToFlakinessDashboardServer = function(testType)
 {
-    // FIXME: Encode whether the test uploads to the server in the buildbot json so
-    // we can include that data in buildbot.jsonp and not need to do ugly heuristics
-    // based off the name of the test suite. This code both has some false positives
-    // and some false negatives.
-    return !testType.match(/_only|_ignore|_perf$/) && !testType.match(/^memory test:|install_/) && testType != 'Run tests';
+    for (var i = 0; i < builders.noUploadTestTypes.length; i++) {
+        if (string.contains(testType, builders.noUploadTestTypes[i]))
+            return false;
+    }
+    return true;
 }
 
 var currentBuilderGroup = {};
 var testTypesThatRunToTBlinkBots = ['layout-tests', 'webkit_unit_tests'];
 
 builders.getBuilderGroup = function(groupName, testType)
 {
     if (!builders in currentBuilderGroup) {
         currentBuilderGroup = builders.loadBuildersList(groupName, testType);
     }
@@ skipping 141 matching lines @@
         if (prev.indexOf(curr) == -1) {
             prev.push(curr);
         }
         return prev;
     }, []);
 
     return groupNames;
 }
 
 })();