Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 309773003: Do not do infobar auto login in Incognito. (Closed)

Created:
6 years, 6 months ago by acleung1
Modified:
6 years, 6 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Do not do infobar auto login in Incognito. BUG=367915 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274630

Patch Set 1 #

Patch Set 2 : Do not show autologin infobar in Incognito mode. #

Total comments: 4

Patch Set 3 : fix empty lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/ui/android/infobars/auto_login_prompter.cc View 1 2 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
acleung1
6 years, 6 months ago (2014-06-02 23:20:53 UTC) #1
gone
On 2014/06/02 23:20:53, acleung1 wrote: lgtm
6 years, 6 months ago (2014-06-02 23:26:57 UTC) #2
gone
https://chromiumcodereview.appspot.com/309773003/diff/20001/chrome/browser/ui/android/infobars/auto_login_prompter.cc File chrome/browser/ui/android/infobars/auto_login_prompter.cc (right): https://chromiumcodereview.appspot.com/309773003/diff/20001/chrome/browser/ui/android/infobars/auto_login_prompter.cc#newcode78 chrome/browser/ui/android/infobars/auto_login_prompter.cc:78: nit: remove empty line https://chromiumcodereview.appspot.com/309773003/diff/20001/chrome/browser/ui/android/infobars/auto_login_prompter.cc#newcode83 chrome/browser/ui/android/infobars/auto_login_prompter.cc:83: this one too?
6 years, 6 months ago (2014-06-02 23:27:05 UTC) #3
acleung1
https://codereview.chromium.org/309773003/diff/20001/chrome/browser/ui/android/infobars/auto_login_prompter.cc File chrome/browser/ui/android/infobars/auto_login_prompter.cc (right): https://codereview.chromium.org/309773003/diff/20001/chrome/browser/ui/android/infobars/auto_login_prompter.cc#newcode78 chrome/browser/ui/android/infobars/auto_login_prompter.cc:78: On 2014/06/02 23:27:05, dfalcantara wrote: > nit: remove empty ...
6 years, 6 months ago (2014-06-03 17:15:32 UTC) #4
acleung1
The CQ bit was checked by acleung@chromium.org
6 years, 6 months ago (2014-06-03 17:15:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acleung@chromium.org/309773003/40001
6 years, 6 months ago (2014-06-03 17:16:46 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 21:12:19 UTC) #7
Message was sent while issue was closed.
Change committed as 274630

Powered by Google App Engine
This is Rietveld 408576698