Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 309773002: Put color util and color analysis tests into color_utils namespace. (Closed)

Created:
6 years, 6 months ago by calamity
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Put color util and color analysis tests into color_utils namespace. This CL is a precursor for https://codereview.chromium.org/289283004/. BUG=376613 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274343

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -57 lines) Patch
M ui/gfx/color_analysis_unittest.cc View 19 chunks +23 lines, -37 lines 0 comments Download
M ui/gfx/color_utils_unittest.cc View 6 chunks +22 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
calamity
6 years, 6 months ago (2014-06-02 03:50:49 UTC) #1
Alexei Svitkine (slow)
LGTM
6 years, 6 months ago (2014-06-02 13:44:38 UTC) #2
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 6 months ago (2014-06-02 13:44:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/309773002/20001
6 years, 6 months ago (2014-06-02 13:45:14 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 19:30:01 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 21:41:05 UTC) #6
Message was sent while issue was closed.
Change committed as 274343

Powered by Google App Engine
This is Rietveld 408576698