Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 309763003: Fix HPushArguments instruction. (Closed)

Created:
6 years, 6 months ago by Benedikt Meurer
Modified:
6 years, 6 months ago
Reviewers:
Jarin
CC:
v8-dev
Visibility:
Public.

Description

Fix HPushArguments instruction. Use the zone that is passed to New() and fix implementation of HPushArguments::AddInput() to match HPhi::AddInput(). R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -51 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 14 chunks +15 lines, -18 lines 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +35 lines, -32 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 6 months ago (2014-06-02 06:11:32 UTC) #1
Jarin
lgtm
6 years, 6 months ago (2014-06-02 06:39:38 UTC) #2
Benedikt Meurer
6 years, 6 months ago (2014-06-02 06:43:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21591 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698