Issue 309763002: Remove RenderEmbeddedObject::layerTypeRequired().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 309763002: Remove RenderEmbeddedObject::layerTypeRequired(). (Closed)

Created:
6 years, 6 months ago by jbroman

Modified:
6 years, 6 months ago

Reviewers:
tkent, eseidel, ojan

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink, abarth-chromium, esprehn, ojan

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove RenderEmbeddedObject::layerTypeRequired(). This method does not seem to do anything useful. It overrides RenderPart::layerTypeRequired(), which does exactly the same thing. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175297

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -11 lines)			Patch
	M	Source/core/rendering/RenderEmbeddedObject.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	Source/core/rendering/RenderEmbeddedObject.cpp	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/309763002/1

6 years, 6 months ago (2014-06-02 17:00:58 UTC) #4

Message was sent while issue was closed.

Change committed as 175297

Expand Messages | Collapse Messages