Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1010)

Unified Diff: Source/core/rendering/compositing/CompositingReasonFinder.cpp

Issue 309743002: Move computation of RenderLayer::isUnclippedDescendant into CompositingPropertyUpdater (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: less assert Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/compositing/CompositingReasonFinder.cpp
diff --git a/Source/core/rendering/compositing/CompositingReasonFinder.cpp b/Source/core/rendering/compositing/CompositingReasonFinder.cpp
index 8f2bda03a963d6e6c4649a077ae32130dd4ce6f5..e78fb944962afae68ba34ae0198529c3113a3103 100644
--- a/Source/core/rendering/compositing/CompositingReasonFinder.cpp
+++ b/Source/core/rendering/compositing/CompositingReasonFinder.cpp
@@ -142,7 +142,10 @@ CompositingReasons CompositingReasonFinder::nonStyleDeterminedDirectReasons(cons
RenderObject* renderer = layer->renderer();
if (hasOverflowScrollTrigger()) {
- if (layer->isUnclippedDescendant())
+ // IsUnclippedDescendant is only actually stale during the chicken/egg code path.
+ // FIXME: Use ancestorDependentProperties().isUnclippedDescendant to ASSERT that
+ // this value isn't stale.
Ian Vollick 2014/06/01 19:25:36 What would you think of using the disabler here?
abarth-chromium 2014/06/01 19:49:36 There isn't a disabler for this ASSERT because it'
+ if (layer->potentiallyStaleIsUnclippedDescendant())
directReasons |= CompositingReasonOutOfFlowClipping;
if (layer->scrollParent())

Powered by Google App Engine
This is Rietveld 408576698