Source/core/rendering/RenderLayerStackingNode.cpp - Issue 309743002: Move computation of RenderLayer::isUnclippedDescendant into CompositingPropertyUpdater

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderLayerStackingNode.cpp

Issue 309743002: Move computation of RenderLayer::isUnclippedDescendant into CompositingPropertyUpdater (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: less assert Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/rendering/RenderLayer.cpp ('k') | Source/core/rendering/compositing/CompositingPropertyUpdater.h » ('j') | Source/core/rendering/compositing/CompositingReasonFinder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderLayerStackingNode.cpp

diff --git a/Source/core/rendering/RenderLayerStackingNode.cpp b/Source/core/rendering/RenderLayerStackingNode.cpp

index 087cf9a7d6beb58d1aecbc1cbf463140713f6aeb..f335b4bd269a3342f9d6e2c878267c68c83608cc 100644

--- a/Source/core/rendering/RenderLayerStackingNode.cpp

+++ b/Source/core/rendering/RenderLayerStackingNode.cpp

@@ -114,10 +114,8 @@ void RenderLayerStackingNode::dirtyZOrderLists()

m_descendantsAreContiguousInStackingOrderDirty = true;

- if (!renderer()->documentBeingDestroyed()) {

- compositor()->setNeedsUpdateCompositingRequirementsState();

+ if (!renderer()->documentBeingDestroyed())

compositor()->setCompositingLayersNeedRebuild();

- }

}

void RenderLayerStackingNode::dirtyStackingContextZOrderLists()

@@ -317,8 +315,6 @@ void RenderLayerStackingNode::updateStackingNodesAfterStyleChange(const RenderSt

dirtyZOrderLists();

else

clearZOrderLists();

- compositor()->setNeedsUpdateCompositingRequirementsState();

}

bool RenderLayerStackingNode::shouldBeNormalFlowOnly() const