Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4055)

Unified Diff: Source/core/testing/Internals.cpp

Issue 309743002: Move computation of RenderLayer::isUnclippedDescendant into CompositingPropertyUpdater (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: polish Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/testing/Internals.cpp
diff --git a/Source/core/testing/Internals.cpp b/Source/core/testing/Internals.cpp
index 7624d3559af7110298088b32ffbb7c45a4b3c7b2..eb48a0c2f7d3ad6bb64d350b5536b3d8d0067ee8 100644
--- a/Source/core/testing/Internals.cpp
+++ b/Source/core/testing/Internals.cpp
@@ -1690,7 +1690,13 @@ bool Internals::isUnclippedDescendant(Element* element, ExceptionState& exceptio
return 0;
}
- return layer->isUnclippedDescendant();
+ // We used to compute isUnclippedDescendant only when acceleratedCompositingForOverflowScrollEnabled,
+ // but now we compute it all the time.
+ // FIXME: Remove this if statement and rebaseline the tests that make this assumption.
+ if (!layer->compositor()->acceleratedCompositingForOverflowScrollEnabled())
+ return false;
+
+ return layer->ancestorDependentProperties().isUnclippedDescendant;
}
String Internals::layerTreeAsText(Document* document, unsigned flags, ExceptionState& exceptionState) const

Powered by Google App Engine
This is Rietveld 408576698